Closed
Bug 1412792
Opened 7 years ago
Closed 6 years ago
Update graphene-django/graphene/graphql-core to v2
Categories
(Tree Management :: Treeherder: API, enhancement, P2)
Tree Management
Treeherder: API
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: camd)
References
Details
Attachments
(3 files)
pyup-bot opened up three PRs for updating to the new v2 release: https://github.com/mozilla/treeherder/pull/2876 https://github.com/mozilla/treeherder/pull/2877 https://github.com/mozilla/treeherder/pull/2878 However: (a) they need to land all at the same time, (b) there are backwards in-compatible changes that will need adjustments on our side (c) we should probably wait for a point release See: https://github.com/graphql-python/graphene/blob/master/UPGRADE-v2.0.md https://github.com/graphql-python/graphene/releases/tag/v2.0.0 https://github.com/graphql-python/graphql-core/releases/tag/v2.0.0
Reporter | ||
Comment 1•7 years ago
|
||
So one of the bugs we were seeing (https://github.com/graphql-python/graphene-django/issues/197) has now been fixed on graphene-django master, so should be released soon. However we'll need to upgrade to the 2.x series to see the benefit.
Reporter | ||
Updated•7 years ago
|
Priority: P3 → P2
Comment 2•6 years ago
|
||
Comment 3•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/457fe485ba67f9954e7a7ccb2d888f1d5ff59732 Bug 1412792 - Add pyup ignore markers for graphene-django v2 (#3058) To keep pyup.io quiet for now, since the upgrade will need to be performed manually.
Comment 4•6 years ago
|
||
Comment 5•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/037643227a1cfc7e42692409b7015c93130bcf25 Bug 1412792 - Update pyup ignore marker for graphene (#3063) Since 1.4.2 has too strict requirements, so we can't use it either. (See #3060)
Reporter | ||
Comment 6•6 years ago
|
||
Cameron, I've combined the three pyup bot PRs into one branch that can be a starting point for the upgrade, in case that helps? https://github.com/mozilla/treeherder/compare/grahene-django-v2 The Travis run for that is here: https://travis-ci.org/mozilla/treeherder/builds/319789221
Comment 7•6 years ago
|
||
Assignee | ||
Comment 8•6 years ago
|
||
Comment on attachment 8940005 [details] [review] Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3105 I rebased, fixed the backward breakages and tested this against the test-view and all seems well with this now. Thanks for generating the branch for me! :)
Attachment #8940005 -
Flags: review?(emorley)
Reporter | ||
Updated•6 years ago
|
Assignee: nobody → cdawson
Status: NEW → ASSIGNED
Reporter | ||
Comment 9•6 years ago
|
||
Comment on attachment 8940005 [details] [review] Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3105 Left a comment :-)
Attachment #8940005 -
Flags: review?(emorley)
Assignee | ||
Comment 10•6 years ago
|
||
Unfortunately my change was merged 2 weeks after this release, so we'll have to wait for the next point release to remove the work-around. :(
Assignee | ||
Comment 11•6 years ago
|
||
Comment on attachment 8940005 [details] [review] Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3105 This is probably fine to merge, given the circumstances, but I don't want to do so without your shiny r+ :)
Attachment #8940005 -
Flags: review?(emorley)
Reporter | ||
Comment 12•6 years ago
|
||
Comment on attachment 8940005 [details] [review] Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3105 Many thanks :-)
Attachment #8940005 -
Flags: review?(emorley) → review+
Comment 13•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/3169121824198682b48193b5e65e2f2564c20a6f Bug 1412792 - Update graphene-django/graphene/graphql-core to v2 (#3105)
Reporter | ||
Updated•6 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•