1412822 - MutableBlobStorage should release the FileDescriptor when an error occurs

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Andrea Marchesini [:baku]]

This is a follow up of bug 1411578.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: mutable2.patch

If we don't release the FD before sending the last message to the parent actor, this actor will not be able to remove the temporary file on windows.

Comment 2

[Andreas Pehrson [:pehrsons]]

For MediaRecorder it looks like an error in MutableBlobStorage is not propagated to the recorder until the recorder asks for a blob (which could be hours later once the recording is finished). We'd need to get informed as soon as possible. Thoughts on fixing this baku?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8923358 [details] [diff] [review]
mutable2.patch

># HG changeset patch
># User Andrea Marchesini <[e-mail]>
># Parent  83996ad23d5057b632dc653880123cb8d2d26b4c
>
>diff --git a/dom/file/MutableBlobStorage.cpp b/dom/file/MutableBlobStorage.cpp
>--- a/dom/file/MutableBlobStorage.cpp
>+++ b/dom/file/MutableBlobStorage.cpp
>@@ -100,86 +100,84 @@ private:
> };
> 
> // This runnable moves a buffer to the IO thread and there, it writes it into
> // the temporary file.
please improve this to indicate that the file may be closed too, since closing is 
a bit surprising result of this runnable

Comment 4

[Andrea Marchesini [:baku]]

> [...] soon as possible. Thoughts on fixing this baku?

Right! Let's do it in a separate bug.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e064bf3ca8e1
MutableBlobStorage should release the FileDescriptor when an error occurs, r=smaug

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e064bf3ca8e1

Comment 7

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/e064bf3ca8e1