Closed Bug 1412822 Opened 6 years ago Closed 6 years ago
Blob Storage should release the File Descriptor when an error occurs
This is a follow up of bug 1411578.
If we don't release the FD before sending the last message to the parent actor, this actor will not be able to remove the temporary file on windows.
Assignee: nobody → amarchesini
Attachment #8923358 - Flags: review?(bugs)
For MediaRecorder it looks like an error in MutableBlobStorage is not propagated to the recorder until the recorder asks for a blob (which could be hours later once the recording is finished). We'd need to get informed as soon as possible. Thoughts on fixing this baku?
Comment on attachment 8923358 [details] [diff] [review] mutable2.patch ># HG changeset patch ># User Andrea Marchesini <firstname.lastname@example.org> ># Parent 83996ad23d5057b632dc653880123cb8d2d26b4c > >diff --git a/dom/file/MutableBlobStorage.cpp b/dom/file/MutableBlobStorage.cpp >--- a/dom/file/MutableBlobStorage.cpp >+++ b/dom/file/MutableBlobStorage.cpp >@@ -100,86 +100,84 @@ private: > }; > > // This runnable moves a buffer to the IO thread and there, it writes it into > // the temporary file. please improve this to indicate that the file may be closed too, since closing is a bit surprising result of this runnable
Attachment #8923358 - Flags: review?(bugs) → review+
> [...] soon as possible. Thoughts on fixing this baku? Right! Let's do it in a separate bug.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e064bf3ca8e1 MutableBlobStorage should release the FileDescriptor when an error occurs, r=smaug
You need to log in before you can comment on or make changes to this bug.