Closed
Bug 1412906
Opened 7 years ago
Closed 6 years ago
Remove config/makefiles/test/
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox60 fixed)
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: ted, Assigned: ted)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
12.08 KB,
patch
|
nalexander
:
review+
|
Details | Diff | Splinter Review |
There are some Makefiles in here that are ostensibly build system unit tests, but they don't seem very high value: https://hg.mozilla.org/mozilla-central/file/515407ebfa1433c31144374313bbfd8b942af41c/config/makefiles/test/ We should just remove that whole directory. The only place that references it is here: https://hg.mozilla.org/mozilla-central/file/515407ebfa1433c31144374313bbfd8b942af41c/config/moz.build#l17 I'm not sure that those tests even get run given the way that's wired up.
Comment 1•7 years ago
|
||
I agree they should be removed.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → ted
Comment 2•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f037ef1acbf7be1c248b70d273d775a7ebe2c929
Updated•6 years ago
|
Attachment #8954056 -
Flags: review?(core-build-config-reviews)
Comment 3•6 years ago
|
||
Comment on attachment 8954056 [details] [diff] [review] bug1412906.patch Review of attachment 8954056 [details] [diff] [review]: ----------------------------------------------------------------- lgtm.
Attachment #8954056 -
Flags: review?(core-build-config-reviews) → review+
Pushed by kmoir@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fdf5c4023c83 Remove config/makefiles/test/ r=nalexander DONTBUILD
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fdf5c4023c83
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•