Closed Bug 1412916 Opened 2 years ago Closed 2 years ago

fill in missing bugzilla_components

Categories

(Firefox Build System :: General, enhancement)

54 Branch
enhancement
Not set

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

Attachments

(1 file, 1 obsolete file)

we have 4 files that show up in missing.json in the bugzilla job on treeherder:
0	"npm-shrinkwrap.json"
1	"package.json"
2	"testing/mach_commands.pyc"
3	"testing/web-platform/moz.build"
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #8923491 - Flags: review?(gps)
Comment on attachment 8923491 [details] [diff] [review]
associate the last few files in tree to bugzilla components

Review of attachment 8923491 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/moz.build
@@ +8,5 @@
>  with Files("*.py"):
>      BUG_COMPONENT = ("Testing", "General")
>  
> +with Files("*.pyc"):
> +    BUG_COMPONENT = ("Testing", "General")

Eh? We should *never* have a .pyc file checked into the repo (assuming it is a Python .pyc file).

::: testing/web-platform/moz.build
@@ +30,5 @@
>          'web-platform-tests-wdspec',
>      ]
>  
> +with Files("moz.build"):
> +    BUG_COMPONENT = ("Core", "Build Config")

moz.build files belong to the component they are part of. I think this should be Testing :: web-platform-tests.
Attachment #8923491 - Flags: review?(gps) → review-
thanks for the review, I have addressed the 2 items.
Attachment #8923491 - Attachment is obsolete: true
Attachment #8923498 - Flags: review?(gps)
Attachment #8923498 - Flags: review?(gps) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/af9dfcf3652d
fill in missing bugzilla_components. r=gps
unfortunately doing |with Files("*")| covers all files in all subdirs, for example the webdriver stuff is pending in a patch, but shows:
$ ./mach file-info bugzilla-component testing/webdriver/**
Testing :: General
  testing/webdriver/Cargo.toml
  testing/webdriver/README.md
  testing/webdriver/src


If I remove the |with Files("*"):| in testing/moz.build, I get this:
elvis@JMAHER-WIN10 ~/mozilla-inbound
$ ./mach file-info bugzilla-component testing/webdriver/**
UNKNOWN
  testing/webdriver/Cargo.toml
  testing/webdriver/README.md
  testing/webdriver/src


We added this statement to cover mach_commands.pyc, I think it is incorrect as now any new files coming into web-platform-tests, etc. will show up as testing::general and when bugs are filed (i.e. intermittent-filer) they will be in testing::general instead of being a flag to ask questions as we have missing data.

:gps, I would like to change this so that we don't blanket all files into testing::general- do you have ideas on how to do that?
Flags: needinfo?(gps)
https://hg.mozilla.org/mozilla-central/rev/af9dfcf3652d
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Your shell expands "testing/webdriver/**" to "testing/webdriver/<all entries>/*". Put single quotes around "testing/webdriver/**" to avoid shell expansion. e.g.

  $ ./mach file-info bugzilla-component 'testing/webdriver/**'
Flags: needinfo?(gps)
my point is that the testing/webdriver/ files are annotated with this patch in the bugzilla job as testing::general instead of unknown- Is it possible that our shell used for generating components.json and missing.json do the same thing?
Flags: needinfo?(gps)
You can see from https://tools.taskcluster.net/groups/Z3bREIECSTqObk08CCMX8w/tasks/AvHA52KlSUKG5umJrxeu7A/details that the ** is single quoted. So, no, this shouldn't impact automation. Although I wouldn't be surprised if there were a quoting bug.

I would create a dedicated mach sub-command to do exactly what we want for automation to eliminate this class of failure. We'll probably want to do that anyway so a) we avoid a redundant read of all moz.build files b) we change the exit code to 1 to fail the task if there are files missing annotations.
Flags: needinfo?(gps)
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.