Closed Bug 1412954 Opened 4 years ago Closed 4 years ago

test_ext_permission_xhr.html is mistakenly disabled

Categories

(WebExtensions :: General, defect, P1)

defect

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: bsilverberg, Assigned: bsilverberg)

Details

Attachments

(1 file)

When [1] was created for bug 1357635, the reference to test_ext_proxy.html was removed from the mochitest-common.ini file, but the code to disable that test was left in place, which now points to test_ext_permission_xhr.html, which was above test_ext_proxy.html in the file.

This bug is to remove that line to re-enable the test.

[1] https://hg.mozilla.org/mozilla-central/rev/f3342ea446a5
Priority: P3 → P1
Comment on attachment 8923529 [details]
Bug 1412954 - Re-enable test_ext_permission_xhr.html,

https://reviewboard.mozilla.org/r/194654/#review199688
Attachment #8923529 - Flags: review+
Comment on attachment 8923529 [details]
Bug 1412954 - Re-enable test_ext_permission_xhr.html,

https://reviewboard.mozilla.org/r/194654/#review199692
Attachment #8923529 - Flags: review?(mixedpuppy) → review+
Pushed by bsilverberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2078ffcbf566
Re-enable test_ext_permission_xhr.html, r=kmag,mixedpuppy
https://hg.mozilla.org/mozilla-central/rev/2078ffcbf566
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.
Flags: needinfo?(bob.silverberg)
Flags: needinfo?(bob.silverberg) → qe-verify-
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.