Closed Bug 1412967 Opened 4 years ago Closed 4 years ago

kill releaserunner2 and adjust the regex patterns accordingly

Categories

(Release Engineering :: Release Automation: Other, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mtabara, Assigned: mtabara)

References

Details

Attachments

(3 files, 1 obsolete file)

In bug 1410182 we added releaserunner3 to handle in-tree Fennec. The corresponding in-tree changes are riding the trains, so are the Fennec regex patterns. 

Therefore, *once* 58 hits release, we can:
* kill releaserunner2
* have releaserunner3 be the future by grabbing all the Fennec releases (possibly Firefox too if we manage to make the full switch by then)

This bug is to track that work.
Prepping some patches in advance for January since I have the context at hand. This is to land when 58 will be in release.
Assignee: nobody → mtabara
Attachment #8923551 - Flags: review?(rail)
Comment on attachment 8923551 [details] [diff] [review]
Kill release-runner2 and adjust fennec patterns.

Review of attachment 8923551 [details] [diff] [review]:
-----------------------------------------------------------------

Yay! LGTM!

BTW, after we land this patch, we should manually delete the corresponding directories on bm83/bm85.
Attachment #8923551 - Flags: review?(rail) → review+
(In reply to Rail Aliiev [:rail] ⌚️ET from comment #2)
> Comment on attachment 8923551 [details] [diff] [review]
> Kill release-runner2 and adjust fennec patterns.
> 
> Review of attachment 8923551 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Yay! LGTM!
> 
> BTW, after we land this patch, we should manually delete the corresponding
> directories on bm83/bm85.

Absolutely! And stop/remove the supervisor processes.
@mtabara, merges are this week! Anything to do here before or during the merge?
Flags: needinfo?(mtabara)
(In reply to Jordan Lund (:jlund) from comment #4)
> @mtabara, merges are this week! Anything to do here before or during the
> merge?

Oh, good point. Totally forgotten of this bug. Thanks for resurrecting this.
Will take a look later on today to refresh my memory on what's going on.
Leaving the NI until then, thanks!
Note to all, some context
* releaserunner is the traditional RR handling the releasetasks / BBB stuff.
* releaserunner2 is a simplified releaserunner that *only* handles Fennec. Its purpose was to serve 56 and 57
* releaserunner3 is our latest releaserunner, handling all the new tcmigration stuff with action tasks and all the goodies.

Right now, as moco-config[1] depicts, we have the following:

* bm81 handling TB releases as it has been doing traditionally

* bm83 (staging area - tweaked to ship-it-dev)
=> releaserunner handles {Firefox,Devedition}57
=> releaserunner2 handles Fennec 56, 57
=> releaserunner3 handles {Firefox, Fennec, Devedition}58+

* bm85 (production - tweaked to ship-it)
=> releaserunner handles all {Firefox,Devedition}
=> releaserunner2 handles Fennec 56, 57
=> releaserunner3 handles Fennec 58, 59 and no Firefox/Devedition.

Please remember that:
* 58 is the train riding containing fully TC Fennec in automation / tools / releaserunner2
* 59 is the train riding with tcmigration stuff

With 57 going away tomorrow being merged by 58 in mozilla-release, the situations is as follows:
* we pin releaserunner to just {Firefox,Devedition}58
* we can kill releaserunner2 as 56, 57 are now history
* we pin releaserunner3 to grab {Firefox,Devedition}59 and above and all Fennec releases from now on

[1]: https://dxr.mozilla.org/build-central/source/puppet/manifests/moco-config.pp#268
Comment on attachment 8923551 [details] [diff] [review]
Kill release-runner2 and adjust fennec patterns.

Obsoleting this as I pushed a new patch with refreshed values to reflect the new reality.
Attachment #8923551 - Attachment is obsolete: true
Comment on attachment 8941651 [details]
Bug 1412967 - kill releaserunner2 and adjust rr and rr3 to new regexes.

https://reviewboard.mozilla.org/r/211896/#review217684
Attachment #8941651 - Flags: review?(aki) → review+
@jlund:

Once mergeduty is done tomorrow, we need to:
1) land my patch in puppet, first in default + merge to production
2) (optional) manually cleanup releaserunner folders. That is logging to bm83/bm85 and remove corresponding entries + killing supervisord processes. This step is not mandatory right now and can wait indefinitely. I can take care of it when I come back on Tuesday.
 
So the essential thing to do is to land the above puppet patch and merge to production before the GTB of Devedition 59.0b1 on Friday.
Flags: needinfo?(mtabara)
(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #10)
> @jlund:
> 
> Once mergeduty is done tomorrow, we need to:
> 1) land my patch in puppet, first in default + merge to production
> 2) (optional) manually cleanup releaserunner folders. That is logging to
> bm83/bm85 and remove corresponding entries + killing supervisord processes.
> This step is not mandatory right now and can wait indefinitely. I can take
> care of it when I come back on Tuesday.
>  
> So the essential thing to do is to land the above puppet patch and merge to
> production before the GTB of Devedition 59.0b1 on Friday.

I just landed this to puppet. I am not doing any rr folder cleanup though. This should be on production systems before the gtb of beta59 deved
releaserunner is ignoring Firefox-52.6.0esr-build1:

2018-01-17 12:55:21,788 - DEBUG - "GET /releases/Firefox-52.6.0esr-build1 HTTP/1.1" 200 2488
2018-01-17 12:55:21,789 - INFO - No releases to handle in [{'comment': '', 'ready': ....
Attachment #8943375 - Flags: review?(jlund)
Attachment #8943375 - Flags: review?(jlund) → review+
(In reply to Nick Thomas [:nthomas] (UTC+13) from comment #12)
> Created attachment 8943375 [details] [diff] [review]
> [puppet] ESR52 fix
> 
> releaserunner is ignoring Firefox-52.6.0esr-build1:
> 
> 2018-01-17 12:55:21,788 - DEBUG - "GET /releases/Firefox-52.6.0esr-build1
> HTTP/1.1" 200 2488
> 2018-01-17 12:55:21,789 - INFO - No releases to handle in [{'comment': '',
> 'ready': ....

Thanks for the fix Nick, I totally forgot about esr in my initial patch!
Comment on attachment 8941651 [details]
Bug 1412967 - kill releaserunner2 and adjust rr and rr3 to new regexes.

https://hg.mozilla.org/build/puppet/rev/ba475123e862
Attachment #8941651 - Flags: checked-in+
RR2 is now history.
* I removed the corresponding /builds/releaserunner2 folders from both bm83/bm85
* supervisorctl no longer has any notion of releaserunner2

We can close this now.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Comment on attachment 8945825 [details]
Bug 1412967 - remove release-runner2 from tools repo as well.

https://reviewboard.mozilla.org/r/215926/#review221740

ship it!
Attachment #8945825 - Flags: review?(aki) → review+
No longer blocks: 1575613
You need to log in before you can comment on or make changes to this bug.