Closed
Bug 1413006
Opened 7 years ago
Closed 7 years ago
Use .apk not .ap_ when building --with-gradle
Categories
(Firefox Build System :: Android Studio and Gradle Integration, enhancement)
Firefox Build System
Android Studio and Gradle Integration
Tracking
(firefox58 fixed)
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: nalexander, Assigned: nalexander)
References
Details
Attachments
(1 file)
The exact contents and format of the .ap_ file produced by Gradle changes over time. We should use the real .apk file -- which should be pretty stable -- in preference. In particular, I witness that the new Android-Gradle 2.3+ plugin introduced by Bug 1366644 doesn't pack assets into the .ap_ file at all, leading to missing assets/ in the |mach package| output. Also, the .ap_ files produced by Android-Gradle 3.0+ plugin aren't well-formed ZIP files -- the central directory header is broken and all the encrypted sizes are 0.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8923582 [details] Bug 1413006 - Use .apk not .ap_ when building --with-gradle. https://reviewboard.mozilla.org/r/194712/#review199910
Attachment #8923582 -
Flags: review?(max) → review+
Pushed by nalexander@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9157360e6cd6 Use .apk not .ap_ when building --with-gradle. r=maliu
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9157360e6cd6
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 58 → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•