1413041 - Android builds are going to permafail when Gecko 58 merges to Beta on 2017-11-02

Status: VERIFIED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Android bustage on the next merge day.

This blocks all Android build & test coverage and the first merge of 58 to Beta is happening on Thursday. Please take a look ASAP.

https://treeherder.mozilla.org/logviewer.html#?job_id=140880565&repo=try

checking whether the target C compiler can be used... yes
Traceback (most recent call last):
  File "/builds/worker/workspace/build/src/configure.py", line 127, in <module>
    sys.exit(main(sys.argv))
  File "/builds/worker/workspace/build/src/configure.py", line 29, in main
    sandbox.run(os.path.join(os.path.dirname(__file__), 'moz.configure'))
  File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/configure/__init__.py", line 408, in run
    self._value_for(option)
  File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/configure/__init__.py", line 476, in _value_for
    return self._value_for_option(obj)
  File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/util.py", line 944, in method_call
    cache[args] = self.func(instance, *args)
  File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/configure/__init__.py", line 541, in _value_for_option
    % option_string.split('=', 1)[0])
mozbuild.configure.options.InvalidOptionError: LLVM_CONFIG is not available in this configuration

Comment 1

[Nathan Froyd [:froydnj]]

This sounds more like Stylo for Android being enabled than flipping the default compiler to clang.  Kato-san, would you please take a look?

Comment 2

[Makoto Kato [:m_kato]]

Yes, this seems to be my change.

Comment 3

[Makoto Kato [:m_kato]]

I set LLVM_CONFIG by mobile/android/config/mozconfigs/common via $topsrcdir/build/mozconfig.stylo.  But when disabling stylo, this LLVM_CONFIG causes invalid option error.

Ryan, do you know better value to detect beta or release on mozconfigs?  NIGHTLY_CHANNEL doesn't always set to beta and release even if milestone.txt has no "a1" string.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

We have other logic specific to update channels in our in-tree configs. Try borrowing from those?
https://dxr.mozilla.org/mozilla-central/source/mobile/android/config/mozconfigs/common#71

Comment 5

[Nick Alexander :nalexander [he/him]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #4)
> We have other logic specific to update channels in our in-tree configs. Try
> borrowing from those?
> https://dxr.mozilla.org/mozilla-central/source/mobile/android/config/
> mozconfigs/common#71

This is the best I know of at this time :(  (This whole area is a disaster right now.)  Please prefer IS_NIGHTLY to MOZ_UPDATE_CHANNEL = nightly -- see https://reviewboard.mozilla.org/r/194678/diff/1#index_header for rationale.

Comment 6

[Makoto Kato [:m_kato]]

(In reply to Nick Alexander :nalexander from comment #5)
> (In reply to Ryan VanderMeulen [:RyanVM] from comment #4)
> > We have other logic specific to update channels in our in-tree configs. Try
> > borrowing from those?
> > https://dxr.mozilla.org/mozilla-central/source/mobile/android/config/
> > mozconfigs/common#71
> 
> This is the best I know of at this time :(  (This whole area is a disaster
> right now.)  Please prefer IS_NIGHTLY to MOZ_UPDATE_CHANNEL = nightly -- see
> https://reviewboard.mozilla.org/r/194678/diff/1#index_header for rationale.

Cannot.  IS_NIGHTLY is just set only nightly build per half day. MOZ_UPDATE_CHANNEL often isn't set autoland/m-i/m-c and other branch uses that MOZ_UPDATE_CHANNEL is nightly-<branch name>.  So Although I try it such as "$MOZ_UPDATE_CHANNEL != beta" and "$MOZ_UPDATE_CHANNEL != release", it doesn't detect well.

I think that we should remove when=building_stylo_bindge for LLVM_CONFIG check.

Comment 7

[Mike Hommey [:glandium]]

The simple solution is not to include mozconfig.stylo from mobile/android/config/mozconfigs/common, but from the nightly mozconfigs.

Comment 8

[Makoto Kato [:m_kato]]

Attachment: Bug 1413041 - Don't set LLVM_CONFIG on beta and release.

LLVM_CONFIG is only allowed when building stylo.  If not building it, it causes invalid option error.

mozconfigs doesn't have same value for milestone.is_nightly of moz.configure.
So, to detect nightly version, I analyze milestone.txt.

Review commit: https://reviewboard.mozilla.org/r/195310/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/195310/

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8924109 [details]
Bug 1413041 - Don't set LLVM_CONFIG on beta and release.

Works on Try

Comment 10

[Nick Alexander :nalexander [he/him]]

Sorry, I need to defer to the most experienced peers for this.  I've filed meta Bug 1413580 to have a broader discussion of this situation, which is the bite that keeps on biting.

Comment 11

[Gregory Szorc [:gps]]

Comment on attachment 8924109 [details]
Bug 1413041 - Don't set LLVM_CONFIG on beta and release.

https://reviewboard.mozilla.org/r/195310/#review200564

I'm not a huge fan of reading milestone.txt from a mozconfig. For desktop, we would enable stylo in the appropriate per-channel mozconfigs only. However, Fennec doesn't seem to have per-channel mozconfigs. The closest we have are some tests against MOZ_UPDATE_CHANNEL. But MOZ_UPDATE_CHANNEL semantically refers to the official Mozilla distribution channels which is different from "pre-release build."

Since I can't think of something better to key off of from the mozconfig level without significantly scope bloating, I'm fine with this implementation.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d42cde31f72f
Don't set LLVM_CONFIG on beta and release. r=gps

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d42cde31f72f