Closed Bug 1413044 Opened 7 years ago Closed 7 years ago

nightly 20171030 failed compile nsDBusHandlerApp.cpp:8:33: fatal error: mozilla/DBusHelpers.h: No such file or directory

Categories

(Core :: IPC, defect, P2)

58 Branch
Unspecified
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox-esr52 --- unaffected
firefox56 --- unaffected
firefox57 --- unaffected
firefox58 --- fixed

People

(Reporter: u532768, Assigned: baku)

References

Details

(Keywords: regression)

Attachments

(2 files)

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20171006080222

Steps to reproduce:

updated local nightly repository with latest updates.


Actual results:

12:30.18 In file included from /mnt/to_archive/accum/src/mozilla-central/obj-x86_64-pc-linux-gnu/uriloader/exthandler/Unified_cpp_uriloader_exthandler0.cpp:38:0:
12:30.18 /mnt/to_archive/accum/src/mozilla-central/uriloader/exthandler/nsDBusHandlerApp.cpp:8:33: fatal error: mozilla/DBusHelpers.h: No such file or directory
12:30.18  #include "mozilla/DBusHelpers.h"
12:30.18                                  ^
12:30.18 compilation terminated.
12:30.19 /mnt/to_archive/accum/src/mozilla-central/config/rules.mk:1051: recipe for target 'Unified_cpp_uriloader_exthandler0.o' failed
12:30.19 gmake[5]: *** [Unified_cpp_uriloader_exthandler0.o] Error 1
12:30.19 /mnt/to_archive/accum/src/mozilla-central/config/recurse.mk:73: recipe for target 'uriloader/exthandler/target' failed
12:30.19 gmake[4]: *** [uriloader/exthandler/target] Error 2
12:30.19 gmake[4]: *** Waiting for unfinished jobs....


Expected results:

successful compile
By https://dxr.mozilla.org/mozilla-central/search?q=file%3AnsDBusHandlerApp.cpp - Log.

bug 1412258.
Blocks: 1412258
Component: Untriaged → IPC
Product: Firefox → Core
Maybe it needs a clobber of the objdir..
I usually clobber the objdir immediately after a successful build.  So it would have been with no objdir.  I just updated the hg repository with today's changesets, confirmed that the objdir was not there, and started the build.  Takes a while, will post the result here.
The build with the latest updates failed with the same error.
Flags: needinfo?(amarchesini)
Keywords: regression
OS: Unspecified → Linux
Priority: -- → P2
Attached patch dbus.patchSplinter Review
netwerk/wifi can be disabled. Let's move DBusHelper.h elsewhere.
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
Attachment #8924316 - Flags: review?(bugs)
Attachment #8924316 - Flags: review?(bugs) → review+
Yeah probably related as necko-wifi is disabled on openbsd..
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/11db55881d5e
Move DBusHelper.h in uriloader/exthandler, r=smaug
https://hg.mozilla.org/mozilla-central/rev/11db55881d5e
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
OP here, confirming that latest nightly updates compile fine.  Thanks.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: