1413051 - Fix background-position of help.svg in RTL locales

Status: RESOLVED FIXED

(DevTools :: about:debugging, defect, P4)

Description

[magicp]

Attachment: about_debugging_help-image-in-rtl.png

Steps to reproduce:
1. Start Firefox in RTL locales
2. Navigate to "about:debugging"

Actual Results:
help.svg position is in the left side.

Expected Results:
help.svg position is in the right side in RTL locales.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1413051 - fix aboutdebugging addon tip icon in RTL;

Review commit: https://reviewboard.mozilla.org/r/205104/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205104/

Comment 2

[Alexandre Poirot [:ochameau]]

Comment on attachment 8934149 [details]
Bug 1413051 - fix aboutdebugging addon tip icon in RTL;

https://reviewboard.mozilla.org/r/205104/#review210590

Thanks, looks good.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a0190f060d7
fix aboutdebugging addon tip icon in RTL;r=ochameau

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/0a0190f060d7

Comment 5

[Julien Cristau [:jcristau]]

Is this worth an uplift to beta?

Comment 6

[Julian Descottes [:jdescottes]]

We can let this one ride the trains.

Comment 7

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 58.0a1 (2017-10-30)(AR) on Windows 10, 64 Bit!

This bug's fix is verified with latest Beta(AR)!

Build ID   : 20180128191456
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0

Comment 8

[Mohammed Adam]

I have Tried to Reproduce this same bug with Firefox Beta 59.0b14 (32bit) on Ubuntu Mate (Linux 4.13.0-36-generic) 

But the Bug has been Fixed. 
--------------------------------------------------------------------------------
Firefox Version 59.0b14
Build ID: 20180301022608
User Agent: Mozilla/5.0 (X11; Linux i686; rv:59.0) Gecko/20100101 Firefox/59.0
OS: Linux 4.13.0-36-generic
--------------------------------------------------------------------------------

Status: Fixed & Verified

[testday-20180302]