Closed Bug 1413107 Opened 3 years ago Closed 2 years ago

Remove ending period in Custom Tabs Switch under Settings -> General

Categories

(Firefox for Android :: Settings and Preferences, enhancement, P5)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 59
Tracking Status
firefox59 --- verified

People

(Reporter: cnevinchen, Assigned: wcheng, Mentored)

Details

(Whiteboard: good-first-bug)

Attachments

(1 file)

Whiteboard: good-first-bug
Mentor: cnevinchen
Priority: -- → P5
Thanks for the patch!
You can add  "r?nechen"  (that's me)  in your commit message so the system will notify the reviewer to review your patch.
Assignee: nobody → chengwc
Hi Nevin,

I see some closing periods in multiple summary strings, such as datareporting_wifi_geolocation_summary4 and pref_developer_remotedebugging_wifi_disabled_summary. If this is an issue, I can create a patch to remove all the periods from summary strings. 
Since this is my first time, do I need to file a bug?

Thanks
Attachment #8927583 - Flags: review?(cnevinchen)
Comment on attachment 8927583 [details]
Bug 1413107 - Remove ending period in Custom Tabs Switch under Settings -> General

https://reviewboard.mozilla.org/r/198880/#review207712

No need to change android_strings.dtd cause it just fix a format issue.
Attachment #8927583 - Flags: review?(cnevinchen) → review+
Pushed by nechen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/da8952aba4b9
Remove ending period in Custom Tabs Switch under Settings -> General r=nechen
(In reply to Nevin Chen [:nechen] from comment #4)
> Comment on attachment 8927583 [details]
> Bug 1413107 - Remove ending period in Custom Tabs Switch under Settings ->
> General
> 
> https://reviewboard.mozilla.org/r/198880/#review207712
> 
> No need to change the android_strings.dtd cause it just fix a format issue.
Sorry... No need to change the "string's version" in android_strings.dtd cause it just fixes a formatting issue. So this patch is good here.
https://hg.mozilla.org/mozilla-central/rev/da8952aba4b9
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Verified as fixed on latest Nightly build (59.0a1 - 12/13).
Device: HTC 10 (Android 7.0) and Huawei Honor (Android 5.1.1).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.