1413107 - Remove ending period in Custom Tabs Switch under Settings -> General

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, enhancement, P5)

Description

[Nevin Chen(Not active on Bugzilla)]

This is a follow up bug for https://bugzilla.mozilla.org/show_bug.cgi?id=1405236#c26

Comment 1

[Benjamin Cheng [:wcheng] (Android Engineer)]

Attachment: Bug 1413107 - Remove ending period in Custom Tabs Switch under Settings -> General

Review commit: https://reviewboard.mozilla.org/r/198880/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/198880/

Comment 2

[Nevin Chen(Not active on Bugzilla)]

Thanks for the patch!
You can add  "r?nechen"  (that's me)  in your commit message so the system will notify the reviewer to review your patch.

Comment 3

[Mai Truong [:maiquynhtruong]]

Hi Nevin,

I see some closing periods in multiple summary strings, such as datareporting_wifi_geolocation_summary4 and pref_developer_remotedebugging_wifi_disabled_summary. If this is an issue, I can create a patch to remove all the periods from summary strings. 
Since this is my first time, do I need to file a bug?

Thanks

Comment 4

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8927583 [details]
Bug 1413107 - Remove ending period in Custom Tabs Switch under Settings -> General

https://reviewboard.mozilla.org/r/198880/#review207712

No need to change android_strings.dtd cause it just fix a format issue.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da8952aba4b9
Remove ending period in Custom Tabs Switch under Settings -> General r=nechen

Comment 6

[Nevin Chen(Not active on Bugzilla)]

(In reply to Nevin Chen [:nechen] from comment #4)
> Comment on attachment 8927583 [details]
> Bug 1413107 - Remove ending period in Custom Tabs Switch under Settings ->
> General
> 
> https://reviewboard.mozilla.org/r/198880/#review207712
> 
> No need to change the android_strings.dtd cause it just fix a format issue.
Sorry... No need to change the "string's version" in android_strings.dtd cause it just fixes a formatting issue. So this patch is good here.

Comment 7

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/da8952aba4b9

Comment 8

[Sorina Florean [:sflorean]]

Verified as fixed on latest Nightly build (59.0a1 - 12/13).
Device: HTC 10 (Android 7.0) and Huawei Honor (Android 5.1.1).