Closed
Bug 1413108
Opened 8 years ago
Closed 8 years ago
count is not incremented correctly in MediaCacheStream::Read() when reading the partial block
Categories
(Core :: Audio/Video: Playback, defect, P2)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
INVALID
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Attachments
(1 file)
|
59 bytes,
text/x-review-board-request
|
Details |
http://searchfox.org/mozilla-central/rev/1c4901d060e3953e41088c038b62a0c026c1e1fb/dom/media/MediaCache.cpp#2495
It should be |count += bytes|.
This might explain the decode error when playing flac-s24.flac.
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → jwwang
Priority: -- → P2
Summary: count is not incremented correctly in MediaCacheStream::Read() → count is not incremented correctly in MediaCacheStream::Read() when reading the partial block
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8923715 -
Flags: review?(jyavenard)
There's a `if (count > 0) { break; } just above:
http://searchfox.org/mozilla-central/rev/1c4901d060e3953e41088c038b62a0c026c1e1fb/dom/media/MediaCache.cpp#2461-2464
So presumably at line 2495 `count` should still be zero, and the assignment should therefore be fine.
|
|
Assignee | |
Comment 4•8 years ago
|
||
Yeah, you are right!
|
|
Assignee | |
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8923715 -
Flags: review?(jyavenard)
You need to log in
before you can comment on or make changes to this bug.
Description
•