Enable Fennec Bookmark Management

RESOLVED FIXED in Firefox 58

Status

()

Firefox for Android
General
RESOLVED FIXED
25 days ago
12 hours ago

People

(Reporter: nechen, Assigned: nechen, NeedInfo)

Tracking

unspecified
Firefox 58
Points:
---

Firefox Tracking Flags

(firefox58 fixed)

Details

(Whiteboard: [FNC][SPT58.4][MVP])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

25 days ago
Make Fennec Bookmark Management works on all channels and default on in Switchboard
Comment hidden (mozreview-request)
(Assignee)

Updated

25 days ago
Assignee: nobody → cnevinchen

Comment 2

24 days ago
mozreview-review
Comment on attachment 8923734 [details]
Bug 1413114 - Enable full bookmark management features by default.

https://reviewboard.mozilla.org/r/194876/#review199948
Attachment #8923734 - Flags: review?(topwu.tw) → review+

Comment 3

24 days ago
mozreview-review
Comment on attachment 8923734 [details]
Bug 1413114 - Enable full bookmark management features by default.

https://reviewboard.mozilla.org/r/194876/#review199958

::: mobile/android/base/java/org/mozilla/gecko/bookmarks/BookmarkUtils.java:25
(Diff revision 1)
>      public static boolean isEnabled(Context context) {
> -        return AppConstants.NIGHTLY_BUILD &&
> -                       SwitchBoard.isInExperiment(context, Experiments.FULL_BOOKMARK_MANAGEMENT);
> +        final boolean initialized = SwitchBoard.hasExperimentValues(context, Experiments.FULL_BOOKMARK_MANAGEMENT);
> +        if (!initialized) {
> +            return true;
> +        }
> +        return SwitchBoard.isInExperiment(context, Experiments.FULL_BOOKMARK_MANAGEMENT);

Just wonder would it be better if we add third args on isInExperiment which is the default value, just like the SharedPreferences.getBoolean(String key, boolean defValue). Not a blocker though
Attachment #8923734 - Flags: review?(max) → review+
(Assignee)

Comment 4

22 days ago
mozreview-review-reply
Comment on attachment 8923734 [details]
Bug 1413114 - Enable full bookmark management features by default.

https://reviewboard.mozilla.org/r/194876/#review199958

> Just wonder would it be better if we add third args on isInExperiment which is the default value, just like the SharedPreferences.getBoolean(String key, boolean defValue). Not a blocker though

We can do it and need to have a default value for all experiments.

Comment 5

22 days ago
Pushed by nechen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e1a4d0b5eb15
Enable full bookmark management features by default. r=jwu,maliu
https://hg.mozilla.org/mozilla-central/rev/e1a4d0b5eb15
Status: NEW → RESOLVED
Last Resolved: 22 days ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Duplicate of this bug: 1413136
Whiteboard: [FNC][SPT58.4][MVP]
(Assignee)

Comment 8

12 hours ago
Do we need to uplift this?
Flags: needinfo?(wehuang)
You need to log in before you can comment on or make changes to this bug.