Closed Bug 1413139 Opened 2 years ago Closed 2 years ago

[MIPS32] Fix MacroAssembler::pushValue(const Address&) for stack-based addresses

Categories

(Core :: JavaScript Engine: JIT, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: dragan.mladjenovic, Assigned: dragan.mladjenovic)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.106 Safari/537.36

Steps to reproduce:

Run jit_test.py   dist/bin/js class/super* on mips32.


Actual results:

Tests failing.


Expected results:

Tests passing.
Attached patch bug1413139.patchSplinter Review
Attachment #8923766 - Flags: review?(jdemooij)
Attachment #8923766 - Flags: review?(jdemooij) → review+
Keywords: checkin-needed
Assignee: nobody → dragan.mladjenovic
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1dc55599085e
[MIPS32] Fix MacroAssembler::pushValue(const Address&) for stack-based addresses. r=jandem
Keywords: checkin-needed
Priority: -- → P5
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
https://hg.mozilla.org/mozilla-central/rev/1dc55599085e
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.