1413142 - Enable surfacetexture tiles on android

Status: RESOLVED WONTFIX

(Core :: Graphics: Layers, enhancement, P3)

Description

[Jamie Nicol [:jnicol]]

Bug 1092294 added the ability to use surfacetextures to back tiles on android. It is currently switched off behind the gfx.use-surfacetexture-textures pref. This bug is to fix remaining issues until it can be switched on by default.

* Snorp has mentioned he has seen updateTexImage failures with it enabled.
* There is some uncertainty about whether we call releaseTexImage in all the required places - and missing one such call would cause the content process to hang in ANativeWindow_lock.
* We may need to look at the rect output parameter of ANativeWindow_lock and use it to paint more content (or even the entire tile).
* Once there is more clarity over exactly how the ANativeWindow_lock/unlock and update/releaseTexImage calls should fit in with our TextureClient/Host model, some more assertions should be added. (And perhaps some MOZ_CRASHes can be downgraded to MOZ_ASSERTs).

Comment 1

[Jamie Nicol [:jnicol]]

Attachment: Bug 1413142 - Enable SurfaceTexture tiles on android by default.

Review commit: https://reviewboard.mozilla.org/r/202118/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/202118/

Comment 2

[Jamie Nicol [:jnicol]]

Once bug 1416015 is closed I think it's time to enable this!

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8931023 [details]
Bug 1413142 - Enable SurfaceTexture tiles on android by default.

https://reviewboard.mozilla.org/r/202118/#review207500

Woo!

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

I think we need to hold off, I'm still getting hangs.

Comment 5

[Jamie Nicol [:jnicol]]

We don't use layers/tiles any more