1413159 - Download panel glitches after removing a downloaded file

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect, P3)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: downloads.gif

[Affected versions]:
Firefox 57.0b13 (BuildId:20171030163911)
Firefox 58.0a1  (BuildId:20171030103605)

[Affected platforms]:
- Ubuntu 16.04  64bit
- macOS 10.11.6
- Windows 10 32bit

[Steps to reproduce]:
1. Launch Firefox.
2. Access the http://testsafebrowsing.appspot.com/ webpage.
3. Click a link from the "Desktop Download Warnings" section.
4. Click the "Save File" button.
5. Click the "Remove File" option from the download panel.

[Expected result]:
The item is successfully removed and no issues occur.

[Actual result]:
The download panel is glitching right after the "Remove File" option was selected.

[Regression range]:
This seems like a regression.

I will get back to this as soon as time permits.

[Additional notes]:
For more information regarding this issue please observe the attached screencast.

Comment 1

[:Paolo Amadini]

Likely related to the new Photon panel behavior.

Comment 2

[Emil Ghitta, QA [:emilghitta]]

Back with the regression.

Last good revision: af23e7b6eb9395aecf2a255316da782ca618750a
First bad revision: 35acf942df34d075d1a181db6feeec0a9904f27b

Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=af23e7b6eb9395aecf2a255316da782ca618750a&tochange=35acf942df34d075d1a181db6feeec0a9904f27b

Comment 3

[:Paolo Amadini]

It looks like this was a race condition in the hidePanel call, and is probably fixed now by the PanelMultiView work.

The panel should now close when using the Remove button. Emil, can you confirm this is fixed?

Comment 4

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 60.0a1 (BuildId:20180306100123) and Firefox 59.0b14 (BuildId:20180301022608) on Windows 10 64bit, macOS 10.13 and Ubuntu 16.04 64bit.

It seems that this issue was fixed by Bug 1414244.