1413188 - Add missing "byUser" argument for callback for browser.notifications.onClosed functions

Status: NEW

(WebExtensions :: Frontend, enhancement, P3)

Description

[Erik Westrup]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20171027085204

Steps to reproduce:

The notifications.onClosed event, as documented here,

https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/notifications/onClosed#Browser_compatibility

is not supporting the "byUser" argument to the callback. Chrome do have this argument.

Please add support for this argument, as some addons which works on Chrome does not function properly because this is missing in Firefox. One of these addons is the famous and well-known Pushbullet.

I found a very annoying behavior bug that I described on at Github-issue for a project call Dunst, a desktop notification daemon, until we there found out that the problem lies in Firefox. Read this bug report for an example of what happens because byUser-argument is not supported in Firefox:

https://github.com/dunst-project/dunst/issues/422#issuecomment-340290219

Tl;DR Bring Firefox up to Chrome and add the byUser argument, and browsers add-ons will work better on Firefox and users gets happy! :)

Now that Firefox 57 is soon out of the door, and the official way for Firefox is webextensions, it's of most importance to try to be as compatible with what webextensions out there already use.