1413229 - Don't call CreateWebRenderCommands for event regions display items

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Kartikaya Gupta (email:[e-mail])]

Right now we are calling CreateWebRenderCommands for all event regions display items. This is bad because (a) there are a lot of these items, (b) it's a virtual function call, and (c) it always returns false, so we then run the fallback codepath for these items. All of this is wasted work because the event regions display items are handled separately in WebRenderCommandBuilder and don't paint anything anyway.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1413229 - Stop calling CreateWebRenderCommands for event regions types.

These items don't paint anything and are handled separately, so we don't need
to call CreateWebRenderCommands for them. We could just implement
CreateWebRenderCommands for the item and have it return true unconditionally,
but it's still an extra virtual call. Plus there's existing code in
WebRenderCommandBuilder that's conditioned specifically for event regions so
I prefer keeping all the conditioned code together.

Review commit: https://reviewboard.mozilla.org/r/195038/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/195038/

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8923866 [details]
Bug 1413229 - Stop calling CreateWebRenderCommands for event regions types.

https://reviewboard.mozilla.org/r/195038/#review200098

It's not obvious to me that this will be that much faster, but sure.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Can't hurt, anyway.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d78aef92c79
Stop calling CreateWebRenderCommands for event regions types. r=jrmuizel

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3d78aef92c79