Closed Bug 1413230 Opened 2 years ago Closed 2 years ago

Fix SurfaceTextureHost GL attachment

Categories

(Core :: Graphics: Layers, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: snorp, Assigned: snorp)

References

(Blocks 1 open bug)

Details

(Whiteboard: [gfx-noted])

Attachments

(2 files)

With bug 1092294 enabled I see lots of failures related to not having an attached GL context, so we're not doing that right.
Comment on attachment 8923910 [details]
Bug 1413230 - Expose updateTexImage() and releaseTexImage() failures in GeckoSurfaceTexture JNI wrapper

https://reviewboard.mozilla.org/r/195048/#review200114

Hm are we actually checking for the error results?
Comment on attachment 8923910 [details]
Bug 1413230 - Expose updateTexImage() and releaseTexImage() failures in GeckoSurfaceTexture JNI wrapper

https://reviewboard.mozilla.org/r/195048/#review200114

No, but we weren't before either. I think we will want MOZ_RELEASE_ASSERT around these calls eventually, but not ready for that yet.
Comment on attachment 8923910 [details]
Bug 1413230 - Expose updateTexImage() and releaseTexImage() failures in GeckoSurfaceTexture JNI wrapper

https://reviewboard.mozilla.org/r/195048/#review200114

If the patch doesn't change behavior, I think we should just keep the code the way it is? It's more obvious what we're doing when we explicitly catch the excepetions in Java.
Assignee: nobody → snorp
Whiteboard: [gfx-noted]
Comment on attachment 8923909 [details]
Bug 1413230 - Ensure we are attached to the GL context in SurfaceTextureHostOGL::PrepareTextureSource()

https://reviewboard.mozilla.org/r/195046/#review200448

lgtm
Attachment #8923909 - Flags: review?(jnicol) → review+
Comment on attachment 8923909 [details]
Bug 1413230 - Ensure we are attached to the GL context in SurfaceTextureHostOGL::PrepareTextureSource()

https://reviewboard.mozilla.org/r/195046/#review201814
Attachment #8923909 - Flags: review?(nical.bugzilla) → review+
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5cc779a5d02
Ensure we are attached to the GL context in SurfaceTextureHostOGL::PrepareTextureSource() r=jnicol,nical
https://hg.mozilla.org/mozilla-central/rev/f5cc779a5d02
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.