1413242 - Crash in java.lang.NullPointerException: NativeException NullHandle() [with T = nsWindow::GeckoViewSupport] at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)

Status: RESOLVED WORKSFORME

(Core Graveyard :: Widget: Android, defect, P1)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is 
report bp-b7a63426-2a08-4b96-a1e0-06cf90171031.
=============================================================

Seen while looking at Beta crash stats: http://bit.ly/2iQgsWR. Crashes started using 56 and have continued into 57. 58 is also affected.

Code was touched in Bug 1382861 back in the 56 timeframe. ni on :jchen for some insight

Comment 1

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Also NI James, Nicole for triaging and investigation help. Thanks guys!

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Set window to null after closing (v1)

Set the GeckoView window to null after closing it so we don't try to
reuse it again.

I think we only need this for 57 Beta, because bug 1413698 will address this
issue for 58.

Comment 3

[Nicole Yee (:nicoleyee)]

Hey Ritu,

Looks like we are able to fix this for 57.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8924666 [details] [diff] [review]
Set window to null after closing (v1)

Approval Request Comment
[Feature/Bug causing the regression]: N/A
[User impact if declined]: Possible random crashes when using Fennec
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Very little
[Why is the change risky/not risky?]: This is a speculative fix, but it shouldn't have any negative impact even if it does not work.
[String changes made/needed]: None

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

~580 crashes/week on Fennec 56 release, to give an idea of the scale of the issue. Wontfix for 56.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Low volume crash on 57 beta, too late to fix for 57. We could still take a fix for 58, though.

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8924666 [details] [diff] [review]
Set window to null after closing (v1)

I don't believe the crash volume here justifies this for Fennec RC

Comment 8

[Nicole Yee (:nicoleyee)]

Jim can we land this is 58 please.

Comment 9

[(inactive) Jim Chen [:jchen] [:darchons]]

I think bug 1413698 fixes this bug for 58.

Comment 10

[Nicole Yee (:nicoleyee)]

Jim can we verify that Bug 1413698 fixes this bug then close out this bug?

Comment 11

[(inactive) Jim Chen [:jchen] [:darchons]]

Right now it's hard to say. We'll have to keep an eye on future crashes.

Comment 12

[(inactive) Jim Chen [:jchen] [:darchons]]

No crash on 59 so far.

Comment 13

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1413242 - Don't let disposed window be read from parcels;

It's possible for parcels derived from the session to outlast the
session lifecycle. This patch makes us return null when trying to
retrieve window objects using stale parcels.

Review commit: https://reviewboard.mozilla.org/r/211476/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211476/