1413247 - Remove references to whimsycorn easter egg from beta 57 since it is unreachable

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, enhancement, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

The whimsycorn easter egg will be unreachable in Firefox 57 thanks to a new menu. The attached patch removes references to it from mozilla-beta 57.

We can have a more thorough clean-up patch for Firefox 58 and beyond. The most important part here is removing the two assets which are about 24kb in size.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1413247 - Remove whimsycorn references from #PanelUI since it is unreachable in Firefox57.

Review commit: https://reviewboard.mozilla.org/r/195042/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/195042/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

This is wontfix for 58. Bug 1410666 will track changes for 58.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8923885 [details]
Bug 1413247 - Remove whimsycorn references from #PanelUI since it is unreachable in Firefox57.

https://reviewboard.mozilla.org/r/195042/#review200116

This looks like an easy way of slimming down the 57 build a little bit. Thanks!

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8923885 [details]
Bug 1413247 - Remove whimsycorn references from #PanelUI since it is unreachable in Firefox57.

Approval Request Comment
[Feature/Bug causing the regression]: none
[User impact if declined]: slightly larger download/installer size
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: removes CSS and image that are not accessible in 57
[String changes made/needed]: none

try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=56152144b4281f7bafe97726eb862518d6381b92 (test failures are due to artifact builds being used in try push)

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8923885 [details]
Bug 1413247 - Remove whimsycorn references from #PanelUI since it is unreachable in Firefox57.

Reducing installer size, seems low risk, Beta56+

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/339cb803bbed