1413296 - Remove e10sCohort annotation from Telemetry environment

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[:Felipe Gomes (needinfo for replies!)]

With the removal of the e10s system addon in Firefox 58 (bug 1406212), the e10sCohort annotation will become meaningless, and will remain as the last value that was set in a 57 profile (or be "undefined" for a fresh profile created in 58). So we should now remove it from the Telemetry Environment.

I'm CC'ing some data people to see if any actions are needed to be taken on the server side before continuing with this.

Comment 1

[Chris H-C :chutten]

Since e10sCohort's fairly "new" (introduced in Firefox 46 with bug 1249845) we ought to be mostly in the clear.

Comment 2

[Georg Fritzsche [:gfritzsche]]

Mark, what dependencies does this removal have on the pipeline side?

Comment 3

[Mark Reid [:mreid]]

This information is in several derived datasets, but as :chutten mentioned, I don't think its removal on the client will break anything (since we're already handling older data that doesn't have it).

We should review and remove it from
- Telemetry Batch View    https://github.com/mozilla/telemetry-batch-view
- python_mozetl           https://github.com/mozilla/python_mozetl/
- firefox-data-docs       https://github.com/mozilla/firefox-data-docs

And notify people that they should update their queries/jobs
- in re:dash              https://sql.telemetry.mozilla.org/queries/48445/source
- on atmo

Comment 4

[Mark Reid [:mreid]]

Note that I don't want to block this work on making sure all the above pipeline tasks happen, so I filed bug 1413515 to follow up.

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1413296 - Remove the e10sCohort annotation from the Telemetry environment.

Review commit: https://reviewboard.mozilla.org/r/196320/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196320/

Comment 6

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1413296 - Remove the E10SCohort annotation from a crash test, as it doesn't exist anymore.

Review commit: https://reviewboard.mozilla.org/r/196322/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196322/

Comment 7

[Chris H-C :chutten]

Comment on attachment 8925087 [details]
Bug 1413296 - Remove the e10sCohort annotation from the Telemetry environment.

https://reviewboard.mozilla.org/r/196320/#review201510

There's also an E10SCohort annotation in toolkit/components/crashes/tests/xpcshell/crash.extra you might want to get while you're in the neighbourhood.

Comment 8

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8925088 [details]
Bug 1413296 - Remove the E10SCohort annotation from a crash test, as it doesn't exist anymore.

https://reviewboard.mozilla.org/r/196322/#review201518

LGTM, this was done to reflect the fact that the add-on had its own annotation but it's not even checked for in the test.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e78d237b0310
Remove the e10sCohort annotation from the Telemetry environment. r=chutten
https://hg.mozilla.org/integration/autoland/rev/3084ed8bbb8f
Remove the E10SCohort annotation from a crash test, as it doesn't exist anymore. r=gsvelto

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e78d237b0310
https://hg.mozilla.org/mozilla-central/rev/3084ed8bbb8f