Closed Bug 1413296 Opened 2 years ago Closed 2 years ago

Remove e10sCohort annotation from Telemetry environment

Categories

(Firefox :: General, enhancement)

58 Branch
enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 58
Tracking Status
firefox57 --- unaffected
firefox58 --- fixed

People

(Reporter: Felipe, Assigned: Felipe)

References

Details

Attachments

(2 files)

With the removal of the e10s system addon in Firefox 58 (bug 1406212), the e10sCohort annotation will become meaningless, and will remain as the last value that was set in a 57 profile (or be "undefined" for a fresh profile created in 58). So we should now remove it from the Telemetry Environment.

I'm CC'ing some data people to see if any actions are needed to be taken on the server side before continuing with this.
Since e10sCohort's fairly "new" (introduced in Firefox 46 with bug 1249845) we ought to be mostly in the clear.
See Also: → 1411945
Mark, what dependencies does this removal have on the pipeline side?
Flags: needinfo?(mreid)
Summary: Remove e10sCohort annotation from telemetry → Remove e10sCohort annotation from Telemetry environment
This information is in several derived datasets, but as :chutten mentioned, I don't think its removal on the client will break anything (since we're already handling older data that doesn't have it).

We should review and remove it from
- Telemetry Batch View    https://github.com/mozilla/telemetry-batch-view
- python_mozetl           https://github.com/mozilla/python_mozetl/
- firefox-data-docs       https://github.com/mozilla/firefox-data-docs

And notify people that they should update their queries/jobs
- in re:dash              https://sql.telemetry.mozilla.org/queries/48445/source
- on atmo
Flags: needinfo?(mreid)
See Also: → 1413515
Note that I don't want to block this work on making sure all the above pipeline tasks happen, so I filed bug 1413515 to follow up.
Comment on attachment 8925087 [details]
Bug 1413296 - Remove the e10sCohort annotation from the Telemetry environment.

https://reviewboard.mozilla.org/r/196320/#review201510

There's also an E10SCohort annotation in toolkit/components/crashes/tests/xpcshell/crash.extra you might want to get while you're in the neighbourhood.
Attachment #8925087 - Flags: review?(chutten) → review+
Comment on attachment 8925088 [details]
Bug 1413296 - Remove the E10SCohort annotation from a crash test, as it doesn't exist anymore.

https://reviewboard.mozilla.org/r/196322/#review201518

LGTM, this was done to reflect the fact that the add-on had its own annotation but it's not even checked for in the test.
Attachment #8925088 - Flags: review?(gsvelto) → review+
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e78d237b0310
Remove the e10sCohort annotation from the Telemetry environment. r=chutten
https://hg.mozilla.org/integration/autoland/rev/3084ed8bbb8f
Remove the E10SCohort annotation from a crash test, as it doesn't exist anymore. r=gsvelto
https://hg.mozilla.org/mozilla-central/rev/e78d237b0310
https://hg.mozilla.org/mozilla-central/rev/3084ed8bbb8f
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
You need to log in before you can comment on or make changes to this bug.