Closed Bug 1413302 Opened 3 years ago Closed 3 years ago

imip.css rules are too broad and are interfering with basic HTML emails

Categories

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

Lightning 6.0
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: coding, Assigned: coding)

Details

Attachments

(2 files, 1 obsolete file)

Attached image diff.png
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171030214405

Steps to reproduce:

We at Nextcloud are currently turning our calendar invitation emails into HTML emails.
The HTML code of an Email can be taken from https://gist.github.com/nickvergessen/5ef6c41f8a21751dd253c1f1d846f458
However t



Actual results:

The layout of the emails is messed up by the Lightning plugin, because it's rules are too general (E.g. ".content").


Expected results:

The content of the email should be displayed well, and the CSS should only affect the Lightning content which is displayed below the Email
I patched the chrome/skin/lightning-common/imip.css to just be prefixed with #invitation-table and it still displayes fine:
https://gist.github.com/nickvergessen/3872e0614140b93c62fb44698c05af8d
Sure, we can wrap this better to limit the css scope. However, I would prefer if you could turn invitation-table to a class instead and use .invitation-table then respectively. To do so, you can find the places to look at for invitation-table here [1]. 

Can you prepare a patch that applies to comm-central? Using the file from the packacked versions wouldn't be sufficient for all platforms. You can find here [1] some help how to get to a patch. If you're done, please upload your patch and ask me for review (by setting the r? flag and filling in my nick in the box next to it in the upload window).
 
[1] https://dxr.mozilla.org/comm-central/search?q=invitation-table+path%3Acalendar&redirect=false
[2] https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(coding)
I'm providing the patch with credentials to the original author.
Flags: needinfo?(coding)
Attachment #8926365 - Flags: review?(makemyday)
Comment on attachment 8926365 [details] [diff] [review]
Patch provided to the gist translated over the c-c tree

Review of attachment 8926365 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch, looks good. Can you mae the "emails r?=" in the commit message a "email; r=" and upload an updated version for checkin? You can carry over the r+ for the patch an set the ckeckin-needed keyword.
Attachment #8926365 - Flags: review?(makemyday) → review+
Assignee: nobody → coding
Status: NEW → ASSIGNED
I hope this is what you wanted?
I don't have a lot of time atm to dive into mercurial and the way you handle issues, sorry.
Attachment #8926365 - Attachment is obsolete: true
Comment on attachment 8927727 [details] [diff] [review]
Patch provided to the gist translated over the c-c tree

Yes, thanks.
Attachment #8927727 - Flags: review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/76c38b6ed571
imip.css rules are too broad and are interfering with basic HTML emails. r=MakeMyDay
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Hmm, no 6.1 target here :-(
Flags: needinfo?(philipp)
Version: Lightning 5.4 → Lightning 6.0
Flags: needinfo?(philipp)
Target Milestone: --- → 6.1
You need to log in before you can comment on or make changes to this bug.