Linux GMP sandbox policy for sched_get_priority_{min,max} is broken

RESOLVED FIXED in Firefox 58

Status

()

enhancement
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jld, Assigned: jld)

Tracking

Trunk
mozilla58
Unspecified
Linux
Points:
---

Firefox Tracking Flags

(firefox58 fixed)

Details

(Whiteboard: sb+)

Attachments

(1 attachment)

The GMP sandbox policy handles various syscalls whose names start with "sched_" by requiring that the pid argument be 0, indicating the current thread; a trap function handles the case where the thread's actual tid is used by redoing the syscall with pid 0.

However, we're also applying this to sched_get_priority_{min,max}, which don't target a thread and don't take a pid: the first (and only) argument is a policy ID.
Whiteboard: sb+
Comment on attachment 8924400 [details]
Bug 1413312 - Fix media plugin sandbox policy for sched_get_priority_{min,max}.

https://reviewboard.mozilla.org/r/195690/#review201050
Attachment #8924400 - Flags: review?(gpascutto) → review+
Pushed by jedavis@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ccd1fbb5ea6
Fix media plugin sandbox policy for sched_get_priority_{min,max}. r=gcp
https://hg.mozilla.org/mozilla-central/rev/4ccd1fbb5ea6
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.