1413332 - Make geckoview's BuildConfig under --with-gradle include computed values

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, enhancement)

Description

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

The MOZ_APP_ABI and MOZ_APP_BUILDID values are special, and need to be handled with care in mobile/android/geckoview/build.gradle.  This ticket tracks doing that.

Comment 1

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

Attachment: Bug 1413332 - Make geckoview's BuildConfig under --with-gradle include computed values.

There's already a secret dependency where
mobile/android/base/Makefile.in (and generated AppConstants.java)
depends on $topobjdir/buildid.h, so this shouldn't be much worse than
what we have.

Review commit: https://reviewboard.mozilla.org/r/195174/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/195174/

Comment 2

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

maliu: if you come online before snorp gets to it, can you steal this review?  It's part of trying to make the smali diff smaller.

Comment 3

[Max Liu [:maliu]]

Comment on attachment 8923991 [details]
Bug 1413332 - Make geckoview's BuildConfig under --with-gradle include computed values.

https://reviewboard.mozilla.org/r/195174/#review200390

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8923991 [details]
Bug 1413332 - Make geckoview's BuildConfig under --with-gradle include computed values.

https://reviewboard.mozilla.org/r/195174/#review200540

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d41004b33dc
Make geckoview's BuildConfig under --with-gradle include computed values. r=maliu,snorp

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6d41004b33dc