Closed Bug 1413332 Opened 2 years ago Closed 2 years ago

Make geckoview's BuildConfig under --with-gradle include computed values

Categories

(Firefox Build System :: Android Studio and Gradle Integration, enhancement)

enhancement
Not set

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

Attachments

(1 file)

The MOZ_APP_ABI and MOZ_APP_BUILDID values are special, and need to be handled with care in mobile/android/geckoview/build.gradle.  This ticket tracks doing that.
maliu: if you come online before snorp gets to it, can you steal this review?  It's part of trying to make the smali diff smaller.
Flags: needinfo?(max)
Comment on attachment 8923991 [details]
Bug 1413332 - Make geckoview's BuildConfig under --with-gradle include computed values.

https://reviewboard.mozilla.org/r/195174/#review200390
Attachment #8923991 - Flags: review+
Comment on attachment 8923991 [details]
Bug 1413332 - Make geckoview's BuildConfig under --with-gradle include computed values.

https://reviewboard.mozilla.org/r/195174/#review200540
Attachment #8923991 - Flags: review?(snorp) → review+
Pushed by nalexander@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6d41004b33dc
Make geckoview's BuildConfig under --with-gradle include computed values. r=maliu,snorp
https://hg.mozilla.org/mozilla-central/rev/6d41004b33dc
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Flags: needinfo?(max)
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 58 → mozilla58
You need to log in before you can comment on or make changes to this bug.