`mach try empty` is broken (ImportError: cannot import name EmptyParser)

RESOLVED FIXED in mozilla58

Status

task
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: jwatt, Assigned: ahal)

Tracking

unspecified
mozilla58
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Seems like https://hg.mozilla.org/mozilla-central/rev/7741abf30b9b (bug 1400503) broke `mach try empty`. That changeset references EmptyParser, but there is no such thing, so I get:

ImportError: cannot import name EmptyParser
Blocks: 1400503
Sorry, I think I messed up a rebase and accidentally clobbered the EmptyParser. I'll also add a test for |try empty| so this gets caught next time.
Status: NEW → ASSIGNED
Ah no, I copied the parser from another file and neglected to change the name.
Comment on attachment 8924142 [details]
Bug 1413374 - [tryselect] Fix |mach try empty| regression and add a test,

https://reviewboard.mozilla.org/r/195400/#review200454

No test; so much fun! :)

+1
Comment on attachment 8924142 [details]
Bug 1413374 - [tryselect] Fix |mach try empty| regression and add a test,

https://reviewboard.mozilla.org/r/195400/#review200458
Attachment #8924142 - Flags: review?(armenzg) → review+
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9528ed506a11
[tryselect] Fix |mach try empty| regression and add a test, r=armenzg
https://hg.mozilla.org/mozilla-central/rev/9528ed506a11
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.