1413374 - `mach try empty` is broken (ImportError: cannot import name EmptyParser)

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Jonathan Watt [:jwatt]]

Seems like https://hg.mozilla.org/mozilla-central/rev/7741abf30b9b (bug 1400503) broke `mach try empty`. That changeset references EmptyParser, but there is no such thing, so I get:

ImportError: cannot import name EmptyParser

Comment 1

[Andrew Halberstadt [:ahal]]

Sorry, I think I messed up a rebase and accidentally clobbered the EmptyParser. I'll also add a test for |try empty| so this gets caught next time.

Comment 2

[Andrew Halberstadt [:ahal]]

Ah no, I copied the parser from another file and neglected to change the name.

Comment 3

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1413374 - [tryselect] Fix |mach try empty| regression and add a test,

Review commit: https://reviewboard.mozilla.org/r/195400/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/195400/

Comment 4

[Andrew Halberstadt [:ahal]]

Comment on attachment 8924142 [details]
Bug 1413374 - [tryselect] Fix |mach try empty| regression and add a test,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/195400/diff/1-2/

Comment 5

[Armen [:armenzg]]

Comment on attachment 8924142 [details]
Bug 1413374 - [tryselect] Fix |mach try empty| regression and add a test,

https://reviewboard.mozilla.org/r/195400/#review200454

No test; so much fun! :)

+1

Comment 6

[Armen [:armenzg]]

Comment on attachment 8924142 [details]
Bug 1413374 - [tryselect] Fix |mach try empty| regression and add a test,

https://reviewboard.mozilla.org/r/195400/#review200458

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9528ed506a11
[tryselect] Fix |mach try empty| regression and add a test, r=armenzg

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9528ed506a11