Closed Bug 1413400 Opened 2 years ago Closed 2 years ago

Avoid manual refcounting in libpref

Categories

(Core :: Preferences: Backend, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(2 files)

Because manual refcounting sucks.
Comment on attachment 8924130 [details]
Bug 1413400 (part 1) - Move s{,Default}RootBranch into Preferences. .

https://reviewboard.mozilla.org/r/195382/#review200952

Makes sense to me and is much nicer.
Attachment #8924130 - Flags: review?(nfroyd) → review+
Comment on attachment 8924131 [details]
Bug 1413400 (part 2) - Make Preferences::sPreferences a StaticRefPtr. .

https://reviewboard.mozilla.org/r/195384/#review200954

::: commit-message-113ca:7
(Diff revision 1)
> +- ~Preferences() used to null out sPreference, which is backwards compare to
> +  how this sort of thing normally works.

Nit: "backwards compared..."?
Attachment #8924131 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/352bbd41f1fa04267235faeec42dd463bcf8118a
Bug 1413400 (part 1) - Move s{,Default}RootBranch into Preferences. r=froydnj.

https://hg.mozilla.org/integration/mozilla-inbound/rev/962343e8bdf0f90916487fcf81908589d70ff51f
Bug 1413400 (part 2) - Make Preferences::sPreferences a StaticRefPtr. r=froydnj.
https://hg.mozilla.org/mozilla-central/rev/352bbd41f1fa
https://hg.mozilla.org/mozilla-central/rev/962343e8bdf0
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Assignee: nobody → n.nethercote
You need to log in before you can comment on or make changes to this bug.