1413459 - Decorations get drawn multiple times with selections in webrender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Tommy Kuo (away forever...)]

In bug 1399310, we fixed the issue of drawing decoration lines with multiple times, but it still fails on WebRender.

Comment 1

[Ethan Lin[:ethlin]]

The test case should be same as bug 1399310. When we select the text, the color of the lines shouldn't change. 

"data:text/html,<span style="text-decoration: underline line-through overline rgba(0,0,0,0.25)">laboris nisi ut aliquip ex </span>"

Comment 2

[Jonathan Kew [:jfkthame]]

This was an issue with webrender + bug 1399310 a couple of weeks back, but AFAICT is now fixed. When bug 1399310 is applied to m-c tip, I can no longer reproduce this issue.

(I'm guessing bug 1401653 may have resolved this, but haven't actually tested that.)

Comment 3

[Aria Beingessner [:Gankra]]

Yes, I "fixed" this by making webrender draw the same lines as gecko, so now we look exactly as buggy as gecko. (and both will be for reals fixed by bug 1399310.

Comment 4

[Jonathan Kew [:jfkthame]]

(In reply to Alexis Beingessner [:Gankro] from comment #3)
> Yes, I "fixed" this by making webrender draw the same lines as gecko, so now
> we look exactly as buggy as gecko. (and both will be for reals fixed by bug
> 1399310.

Except that with webrender + bug 1399310, the shadows of decoration lines get clipped incorrectly; see bug 1399310 comment 51 ("The second thing..." there). But that's not -this- bug, it's a bit different.