Apply TimeClip in intl_FormatDateTime and intl_FormatToPartsDateTime

RESOLVED FIXED in Firefox 59

Status

()

P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: anba, Assigned: anba)

Tracking

Trunk
mozilla59
Points:
---

Firefox Tracking Flags

(firefox58 wontfix, firefox59 fixed)

Details

Attachments

(1 attachment)

Priority: -- → P3
(Assignee)

Comment 1

a year ago
Adds the call to TimeClip per the spec PR. I've also moved the invalid-date check into js::intl_FormatDateTime to remove a bit of code duplication and because it looks cleaner to me to pass |ClippedTime| instead of |double| values to intl_Format[ToParts]DateTime(...). 

All test262 from <https://github.com/tc39/test262/pull/1340> pass with the proposed changes.
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #8935356 - Flags: review?(gandalf)
Attachment #8935356 - Flags: review?(gandalf) → review+

Comment 3

a year ago
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/071076af815d
Apply TimeClip in Intl.DateTimeFormat format methods. r=gandalf
Keywords: checkin-needed

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/071076af815d
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
status-firefox58: affected → wontfix
You need to log in before you can comment on or make changes to this bug.