1413540 - Merge 'flash' filter into 'others'

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Remove the 'Flash' filter button from the toolbar and make Flash requests part of the 'Others' filter.

Honza

Comment 1

[Abhinav Koppula]

Hi Honza,
Can I work on this issue?

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Abhinav Koppula from comment #1)
> Hi Honza,
> Can I work on this issue?
Yes please, assigned to you!
Honza

Comment 3

[Abhinav Koppula]

Attachment: Bug 1413540 - Merge 'flash' filter into 'Others'.

Review commit: https://reviewboard.mozilla.org/r/196486/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196486/

Comment 4

[Abhinav Koppula]

Hi Honza,
I have taken a stab at this issue and have fixed the tests failing due to this change.

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8925324 [details]
Bug 1413540 - Merge 'flash' filter into 'Others'.

https://reviewboard.mozilla.org/r/196486/#review201878

Looks great, thanks for the patch Abhinav!
Tested on Win10 and works for me.
R+ assuming try is green
Honza

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1dfd52f82973
Merge 'flash' filter into 'Others'. r=Honza

Comment 7

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/1dfd52f82973

Comment 8

[Chris Mills [:cmills]]

I've added a note to the Network monitor page covering this:

https://developer.mozilla.org/en-US/docs/Tools/Network_Monitor#Toolbar

And one to the 58 rel notes:

https://developer.mozilla.org/en-US/Firefox/Releases/58#Developer_Tools

Once 58 gets to release, I will aim to update the screenshots to not show the Flash button at all.