Closed Bug 1413540 Opened 2 years ago Closed 2 years ago

Merge 'flash' filter into 'others'

Categories

(DevTools :: Netmonitor, enhancement, P3)

enhancement

Tracking

(firefox58 fixed)

RESOLVED FIXED
Firefox 58
Tracking Status
firefox58 --- fixed

People

(Reporter: Honza, Assigned: abhinav.koppula, Mentored)

Details

(Keywords: dev-doc-complete, good-first-bug)

Attachments

(1 file)

Remove the 'Flash' filter button from the toolbar and make Flash requests part of the 'Others' filter.

Honza
Mentor: odvarko
Keywords: good-first-bug
Priority: -- → P3
Hi Honza,
Can I work on this issue?
Flags: needinfo?(odvarko)
Assignee: nobody → abhinav.koppula
Status: NEW → ASSIGNED
Flags: needinfo?(odvarko)
(In reply to Abhinav Koppula from comment #1)
> Hi Honza,
> Can I work on this issue?
Yes please, assigned to you!
Honza
Hi Honza,
I have taken a stab at this issue and have fixed the tests failing due to this change.
Comment on attachment 8925324 [details]
Bug 1413540 - Merge 'flash' filter into 'Others'.

https://reviewboard.mozilla.org/r/196486/#review201878

Looks great, thanks for the patch Abhinav!
Tested on Win10 and works for me.
R+ assuming try is green
Honza
Attachment #8925324 - Flags: review?(odvarko) → review+
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1dfd52f82973
Merge 'flash' filter into 'Others'. r=Honza
Keywords: dev-doc-needed
https://hg.mozilla.org/mozilla-central/rev/1dfd52f82973
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
I've added a note to the Network monitor page covering this:

https://developer.mozilla.org/en-US/docs/Tools/Network_Monitor#Toolbar

And one to the 58 rel notes:

https://developer.mozilla.org/en-US/Firefox/Releases/58#Developer_Tools

Once 58 gets to release, I will aim to update the screenshots to not show the Flash button at all.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.