Closed Bug 1413540 Opened 6 years ago Closed 6 years ago
Merge 'flash' filter into 'others'
Remove the 'Flash' filter button from the toolbar and make Flash requests part of the 'Others' filter. Honza
Priority: -- → P3
Hi Honza, Can I work on this issue?
Assignee: nobody → abhinav.koppula
Status: NEW → ASSIGNED
(In reply to Abhinav Koppula from comment #1) > Hi Honza, > Can I work on this issue? Yes please, assigned to you! Honza
Hi Honza, I have taken a stab at this issue and have fixed the tests failing due to this change.
Comment on attachment 8925324 [details] Bug 1413540 - Merge 'flash' filter into 'Others'. https://reviewboard.mozilla.org/r/196486/#review201878 Looks great, thanks for the patch Abhinav! Tested on Win10 and works for me. R+ assuming try is green Honza
Attachment #8925324 - Flags: review?(odvarko) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/1dfd52f82973 Merge 'flash' filter into 'Others'. r=Honza
I've added a note to the Network monitor page covering this: https://developer.mozilla.org/en-US/docs/Tools/Network_Monitor#Toolbar And one to the 58 rel notes: https://developer.mozilla.org/en-US/Firefox/Releases/58#Developer_Tools Once 58 gets to release, I will aim to update the screenshots to not show the Flash button at all.
You need to log in before you can comment on or make changes to this bug.