Closed
Bug 141356
Opened 22 years ago
Closed 22 years ago
Add JS_[Un]LockGCThingRT()
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
VERIFIED
FIXED
mozilla1.0
People
(Reporter: bryner, Assigned: shaver)
References
Details
(Keywords: js1.5)
Attachments
(1 file, 1 obsolete file)
5.17 KB,
patch
|
bryner
:
review+
brendan
:
superreview+
|
Details | Diff | Splinter Review |
Given that LockGCThing and UnlockGCThing only need a JSRuntime, there should be a version of this that doesn't require a JSContext.
Assignee | ||
Comment 1•22 years ago
|
||
I got yer back. Patch coming up.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0
Assignee | ||
Comment 2•22 years ago
|
||
This builds and the shell starts, and it looks "obviously right" to me, following the pattern established by the Root variants. I haven't tested the browser yet, but my build progresses... Bryner, does this ease your pain?
Reporter | ||
Comment 3•22 years ago
|
||
Well, not quite: JS_PUBLIC_API(JSBool) JS_UnlockGCThingRT(JSRuntime *rt, void *thing) { return JS_UnlockGCThingRT(rt, thing); } is a good exercise in blowing out the stack :) With that fixed, things do seem to work.
Assignee | ||
Comment 4•22 years ago
|
||
Did I say "obviously right"? Who's using my bugzilla account? *ahem*
Comment 5•22 years ago
|
||
Dudes, cc me next time (I'm trying to catch up on my bugmail). /be
Keywords: js1.5,
mozilla1.0
Assignee | ||
Comment 6•22 years ago
|
||
Attachment #81855 -
Attachment is obsolete: true
Reporter | ||
Comment 7•22 years ago
|
||
Comment on attachment 82045 [details] [diff] [review] More patch. Less duh. r=bryner
Attachment #82045 -
Flags: review+
Comment 8•22 years ago
|
||
Comment on attachment 82045 [details] [diff] [review] More patch. Less duh. If you're game, make the parallel name change for js_RemoveRoot (that is, suffix RT to that name). More files to touch, but it's a safe substitution. sr=brendan@mozilla.org /be
Attachment #82045 -
Flags: superreview+
Reporter | ||
Comment 9•22 years ago
|
||
Checked in on the trunk and MOZILLA_1_0_0_BRANCH.
Comment 10•22 years ago
|
||
Patch verified on trunk and branch -
Status: RESOLVED → VERIFIED
Keywords: verified1.0.0
You need to log in
before you can comment on or make changes to this bug.
Description
•