Remove Mozilla specific options as they have been merged upstream

RESOLVED FIXED in Firefox 58

Status

enhancement
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: sylvestre, Assigned: sylvestre)

Tracking

(Blocks 1 bug)

Trunk
mozilla58
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
A few options in .clang-format are no longer useful because they have been enabled in clang-format upstream.
We should remove them.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8925365 [details]
Bug 1413609 - Remove Mozilla specific options as they have been merged upstream

https://reviewboard.mozilla.org/r/196514/#review201790
Attachment #8925365 - Flags: review?(bpostelnicu) → review+

Comment 4

2 years ago
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 7cdc747db6ac -d 25f6ee53ac1c: rebasing 432241:7cdc747db6ac "Bug 1413609 - Remove Mozilla specific options as they have been merged upstream r=andi" (tip)
merging .clang-format
warning: conflicts while merging .clang-format! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request)

Comment 6

2 years ago
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f43442328ed9
Remove Mozilla specific options as they have been merged upstream r=andi

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f43442328ed9
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
(In reply to Sylvestre Ledru [:sylvestre] from comment #0)
> A few options in .clang-format are no longer useful because they have been
> enabled in clang-format upstream.

in which version?
Assignee

Comment 9

2 years ago
5.0 has all of them

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.