1413635 - Refactor AllocKind definition

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement, P3)

Comment 1

[Jon Coppeard (:jonco)]

Attachment: bug1413635-generate-alloc-kind

Some cleanup I noticed during the previous refactoring.

We can generate the AllocKind enum from the FOR_EACH_*_ALLOCKIND macros, although I did have to hardcode the first object alloc kind.  It's checked by a static assert so I think this is OK though.

I merged the background finalizable and nursery allocation flags into these macros too.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: bug1413635-alloc-kind-base

Give AllocKind a uint8_t base and remove casting to size_t.  I check that this didn't change the size of the arena header.

Comment 3

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8924247 [details] [diff] [review]
bug1413635-generate-alloc-kind

Review of attachment 8924247 [details] [diff] [review]:
-----------------------------------------------------------------

Oh good. I never did this because I was scared off by all the different files involved, and I wasn't sure what was visible from where, and just punted.

Comment 4

[Jon Coppeard (:jonco)]

(In reply to Jon Coppeard (:jonco) from comment #2)
> I check that this didn't change the size of the arena header.

Ah, this doesn't work on Windows.

Comment 5

[Jon Coppeard (:jonco)]

(In reply to Jon Coppeard (:jonco) from comment #4)
I'll land this without the change to Arena to use AllocKind rather than size_t for the allocKind member.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec967bb54314
Generate AllocKind enum automatically and include more information in the definition macro r=sfink
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d72b8f7f10a
Give AllocKind enum a uint8_t base r=sfink

Comment 7

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ec967bb54314
https://hg.mozilla.org/mozilla-central/rev/1d72b8f7f10a