Closed Bug 1413668 Opened 2 years ago Closed 2 years ago

Simplify definition of objdir in mozharness configs.

Categories

(Infrastructure & Operations :: CIDuty, task)

task
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
Tracking Status
firefox59 --- fixed

People

(Reporter: tomprince, Assigned: tomprince)

References

Details

Attachments

(4 files)

No description provided.
I can have a look at these tomorrow assuming no further distractions with 57.0. Failing that and these are blocking, we should r? others who have contributed to mozharness build scripts: callek, aki, rail, and mihai are all good candidates.
Comment on attachment 8924310 [details]
Bug 1413668: Don't hardcode objdir in LD_LIBRAY_PATH.

https://reviewboard.mozilla.org/r/195516/#review205146
Comment on attachment 8924311 [details]
Bug 1413668: Don't hardcode MOZ_OBJDIR in mozharness configs.

https://reviewboard.mozilla.org/r/195518/#review205154
Attachment #8924311 - Flags: review?(jlund) → review+
Comment on attachment 8924310 [details]
Bug 1413668: Don't hardcode objdir in LD_LIBRAY_PATH.

https://reviewboard.mozilla.org/r/195516/#review205156
Attachment #8924310 - Flags: review?(jlund) → review+
Comment on attachment 8924312 [details]
Bug 1413668: Factor out objdir configuration in mozharness.

https://reviewboard.mozilla.org/r/195520/#review205148

I'm largely okay with this. Do you suspect we will have more items going into this firefox specific config? If not, perhaps this should be a cli option.

::: taskcluster/ci/artifact-build/kind.yml:38
(Diff revision 2)
>                  TOOLTOOL_MANIFEST: "browser/config/tooltool-manifests/linux64/releng.manifest"
>          run:
>              using: mozharness
>              actions: [get-secrets build]
>              config:
> +                - builds/releng_base_firefox.py

it's been a while since I looked at these, I'm surprised this wasn't using a base config before?
Attachment #8924312 - Flags: review?(jlund) → review+
Comment on attachment 8924337 [details]
Bug 1413668: Disambiguate win64-asan/debug and win64-asan/opt for perfherder.

https://reviewboard.mozilla.org/r/195578/#review205160

was this just missed from the linux* equivalents?
Attachment #8924337 - Flags: review?(jlund) → review+
have you tried out any of these patches anywhere? Hard to eyeball.
Comment on attachment 8924312 [details]
Bug 1413668: Factor out objdir configuration in mozharness.

https://reviewboard.mozilla.org/r/195520/#review205148

Yeah, there is at least one more: https://reviewboard.mozilla.org/r/197776/diff/3#2. I'm not sure if there will be more after that. I'm happy to create a CLI option for these instead.
(In reply to Jordan Lund (:jlund) from comment #15)
> have you tried out any of these patches anywhere? Hard to eyeball.

never mind, I can failed to read mozreview :)
Comment on attachment 8924337 [details]
Bug 1413668: Disambiguate win64-asan/debug and win64-asan/opt for perfherder.

https://reviewboard.mozilla.org/r/195578/#review205160

Yeah, the linux versions already had the `PREFHERDER_EXTRA_OPTIONS`. taskcluster does some sanity checking that is based partly on the first mozharness config, so when I made them all the same, it complained about this.
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/integration/autoland/rev/d9f723a7e03f
Don't hardcode objdir in LD_LIBRAY_PATH. r=jlund
https://hg.mozilla.org/integration/autoland/rev/baa73f2bdc72
Don't hardcode MOZ_OBJDIR in mozharness configs. r=jlund
https://hg.mozilla.org/integration/autoland/rev/724276688605
Factor out objdir configuration in mozharness. r=jlund
https://hg.mozilla.org/integration/autoland/rev/188a60783b36
Disambiguate win64-asan/debug and win64-asan/opt for perfherder. r=jlund
Component: Loan Requests → Buildduty
Product: Release Engineering → Infrastructure & Operations
You need to log in before you can comment on or make changes to this bug.