141367 - remove files containing unused find code from PPEmbed

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: Mac, defect)

Description

[Akkana Peck]

I was working on bug 126312 (remove old find code) when I hit a snag: it seems
the embedding/powerplant code uses the old text services find code explicitly,
rather than going through the frozen interface nsIWebBrowserFind.

Is this part of the embedded app still active?  Is there any reason it needs to
do the logic itself rather than just calling nsIWebBrowserFind?  I'm not sure
what all the code in CFindComponent::SetupDocForSearch is doing -- it's
different from
anything the other find implementations do.

Comment 1

[Conrad Carlen (not reading bugmail)]

CFindComponent.h/.cpp isn't used. It's not compiled and should just be CVS
removed. Didn't notice it was still there.

Comment 2

[Conrad Carlen (not reading bugmail)]

BTW, one thing which that code did, which is still not implemented in what's
behind nsIWebBrowserFind, is "match entire word" searching. It used the
LWBreaker from the doc to check the endpoints of a found pattern for being on
word boundaries. I think that was why I kept the file around: to add that
capability to the new code. However, the new find code is so different from the
TSM code, the old code in CFindComponent is not relevant anymore. Do I need a
patch of the to-be removed files for r= or just yank them? 

Comment 3

[Conrad Carlen (not reading bugmail)]

Changing summary since it does use the new find code.

Comment 4

[Conrad Carlen (not reading bugmail)]

Attachment: diff for removed files

Here's one pretty amusing line that will be removed:

- * Based on nsFindComponent.cpp by Pierre Phaneuf <[e-mail]>

Ahem, that was when I first started with mozilla.

Comment 5

[Conrad Carlen (not reading bugmail)]

If an r=/sr= is needed to remove files, can akkana and kin do that? If not, just
let me know and I'll do it. 

Comment 6

[Akkana Peck]

Comment on attachment 82494 [details] [diff] [review]
diff for removed files

r=akkana, and thanks.

Comment 7

[kinmoz]

Comment on attachment 82494 [details] [diff] [review]
diff for removed files

sr=[e-mail]

Comment 8

[Conrad Carlen (not reading bugmail)]

They're gone. Thanks for quick r=/sr=.