Closed
Bug 1413674
Opened 8 years ago
Closed 8 years ago
update datadog python library to 0.16.0
Categories
(Socorro :: General, task)
Socorro
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: willkg, Assigned: willkg)
References
Details
Attachments
(1 file)
We're using an old old version of the datadog Python library. Since then, they've adjusted the API a bit.
We should update to the newer version. Amongst other things, this lets us use Markus (https://github.com/willkg/markus).
This bug covers that.
Assignee | ||
Comment 1•8 years ago
|
||
We use the datadog library in socorro/external/statsd/* and I think in another place. In both cases, we do:
from datadog.dogstatsd import statsd
and then use that singleton. The newer version of the library still has that, so I think we should be fine.
Grabbing this to do now since it blocks Markus work.
Assignee: nobody → willkg
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
Comment 3•8 years ago
|
||
Commits pushed to master at https://github.com/mozilla-services/socorro
https://github.com/mozilla-services/socorro/commit/adbe87cabb774051aa8a81a0bd2c90f530ddc1fb
fixes bug 1413674 - Update datadog python lib
We use datadog in a few places, but all of them do:
from datadog.dogstatsd import statsd
and the mocks all mock that, too.
Updating the datadog library maintains that statsd instance, so we should be
fine.
https://github.com/mozilla-services/socorro/commit/1ba6253c3ec47ea520cdaf61764b3463e88e559a
Merge pull request #4074 from willkg/1413674-datadog
fixes bug 1413674 - Update datadog python lib
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•8 years ago
|
||
This landed in master and deployed to stage. I watched the Datadog graphs for -stage to see if there was any change in metrics and everything looks fine.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•