Closed Bug 1413696 Opened 7 years ago Closed 7 years ago

Add default prefs for ASan Reporter

Categories

(Firefox Build System :: General, enhancement)

x86_64
Linux
enhancement
Not set
major

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: decoder, Assigned: decoder)

References

(Blocks 1 open bug)

Details

(Keywords: sec-want, Whiteboard: [adv-main58-])

Attachments

(1 file)

With the ASan reporter in our codebase (bug 1386304) and the infrastructure up and running, we can now add the default prefs for the extension. They include the default API endpoint of our infrastructure and the default "unknown" value for clientid. Having these baked into our TC builds will make sure that internal testers have the right settings and that changing your client id is easier.
Comment on attachment 8924331 [details]
Bug 1413696 - Add default prefs for ASan Reporter.

https://reviewboard.mozilla.org/r/195566/#review201084

This seems fine-ish...I assume you have gotten appropriate data-review (?) and/or legal review, or you will obtain such review, before turning this out into the wild?
Attachment #8924331 - Flags: review?(nfroyd) → review+
(In reply to Nathan Froyd [:froydnj] from comment #2)
> Comment on attachment 8924331 [details]
> Bug 1413696 - Add default prefs for ASan Reporter.
> 
> https://reviewboard.mozilla.org/r/195566/#review201084
> 
> This seems fine-ish...I assume you have gotten appropriate data-review (?)
> and/or legal review, or you will obtain such review, before turning this out
> into the wild?

Yes, we do have data review for this and clearance to make it public. But we cannot (and will not) make it a public program yet because we don't have the updates yet for the build (which I consider a prerequisite for a public testing program). So right now, this is constrained to internal testing. But even for that, the settings make it easier because people just need to download the builds.
Pushed by choller@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f532ca793b60
Add default prefs for ASan Reporter. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/f532ca793b60
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Whiteboard: [adv-main58-]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: