1413705 - Find in Page bar needs to respect safe area insets for iPhone X

Status: VERIFIED FIXED

(Firefox for iOS :: Browser, defect, P2)

Description

[Farhan Patel [:farhan]]

The Find in Page bar is not ideal on the iPhone X

The Phone needs to respect the safe area insets on the left/right which should be easy. 

The tricky part will be how to respect the bottom safe area as the toolbar scrolls away.

Comment 1

[Farhan Patel [:farhan]]

Attachment: Simulator Screen Shot - iPhone X - 2017-11-01 at 14.41.57.png

Comment 2

[Jhonatas Rodrigues]

Attachment: Pull request

Comment 3

[Sawyer Blatz [:sblatz]]

We (partially) fixed this on Focus iOS with the following PR: https://github.com/mozilla-mobile/focus-ios/pull/1025

This does not include a landscape fix, unfortunately.

Comment 4

[damian.stanczyk]

Attachment: GitHub Pull Request

Fix based on https://github.com/mozilla-mobile/focus-ios/pull/1025

Comment 5

[Farhan Patel [:farhan]]

merged

Comment 6

[:garvan]

Re-opening as this caused bug https://bugzilla.mozilla.org/show_bug.cgi?id=1506517

Comment 7

[:garvan]

This PR partially reverts this fix https://github.com/mozilla-mobile/firefox-ios/pull/4399

Comment 8

[:garvan]

https://github.com/mozilla-mobile/firefox-ios/pull/4401

Comment 9

[Simon Basca [:SimonB]]

Verifying as fix on master d6d0585a and 15.0b13583.