141373 - Entry for 'japan' not available in regionNames.properties

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Shruti Vasudevan]

The entry 'jp=Japan' is not listed in the file:
http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/locale/en-US/regionNames.properties

Comment 1

[Roy Yokoyama]

->tao

Comment 2

[tao]

It's almost zero risk; add one line into the property file.

Comment 3

[dbragg]

Attachment: Diff with jp = Japan added

Comment 4

[dbragg]

Shruti: could you post a little message here about why this is important for
CCK? It would help with the approval process.

Comment 5

[tao]

Comment on attachment 83800 [details] [diff] [review]
Diff with jp = Japan added

r=tao. Please look at 'Preferences|Navigator|Languages| Add' to see if anything
break. thx!

Comment 6

[tao]

BTW, Don, I notice that the indention is not right. Would you please fix that one?
thx!

Comment 7

[dbragg]

Attachment: New diff using tabs

Actually the alignment wasn't incorrect, it was that I'm not using tabs (per
Mozilla rules).  Turns out that the CCK code is using the existance of tabs in
this file for its parsing. Thus the new patch.

Comment 8

[dbragg]

Ran Tao's test with the tab'd patch and all looks well.

Comment 9

[Shruti Vasudevan]

We are supporting feature to customize localized browsers in CCK. In order to be
consistent with the browser, the language-region description which appears in
the CCK product (drop down to select different language-region) is picked up
directly from the browser properties files (namely language.properties and
region.properties). Since a region entry for 'jp=japan' is not present, the
description for Japanese browser does not appear correctly in CCK tool.

Comment 10

[Shruti Vasudevan]

Refer http://bugscape.netscape.com/show_bug.cgi?id=11874 for more details.

Comment 11

[Daniel Veditz [:dveditz]]

Comment on attachment 83812 [details] [diff] [review]
New diff using tabs

sr=dveditz

Comment 12

[tao]

Comment on attachment 83812 [details] [diff] [review]
New diff using tabs

r=tao

Comment 13

[dbragg]

Ok, so we've got just about every keyword under the sun here except adt1.0.1+. 
Soliciting ADT and drivers for approval.

Comment 14

[tao]

Hi, Don - would you please bring this up to ADT? Zero rsik bug to get over with.
thx!

Comment 15

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 83812 [details] [diff] [review]
New diff using tabs

please check into the 1.0.1 branch ASAP. once landed remove the 
mozilla1.0.1+ keyword and add the fixed1.0.1 keyword

Comment 16

[Jaime Rodriguez, Jr.]

Mass removing adt1.0.0, and adding adt1.0.1 because, we are now on 1.0.1.

Comment 17

[Jaime Rodriguez, Jr.]

adt1.0.1+ (on ADT's behalf) for checkin to the 1.0 branch. Pls check this in
asap. thanks! 

Comment 18

[dbragg]

Fix checked in (finally)

Comment 19

[Kasumi]

verified on 2002-06-26-08-1.0 buld on Windows XP Pro. JA

Comment 20

[lchiang]

katsumi - can you verify this bug fix in branch?  When verified, pls replace
fixed1.0.1 keyword with verified1.0.1.  Thanks.

Comment 21

[Anbo Motohiko]

Attachment 83812 [details] [diff] is not landed on HEAD (trunk). I've opened bug 292414 for this.

Bug 292414 - Entry for 'japan' not available in regionNames.properties on
trunk/aviary branch
https://bugzilla.mozilla.org/show_bug.cgi?id=292414