Open
Bug 1413755
Opened 7 years ago
Updated 2 years ago
Consider using relative paths to specify the source files that should be built
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(Not tracked)
NEW
People
(Reporter: jwatt, Unassigned)
Details
Attachments
(2 files)
821 bytes,
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
3.39 KB,
text/plain
|
Details |
Bug 648053 made us change from specifying the source file that is to be compiled using a relative path to an absolute path. That was to help Eclipse CDT indexing. Nowadays we have a build backend to generate Eclipse CDT projects, and besides that unified builds would have broken the Eclipse Build Output Parser mechanism. Switching back to relative paths would make log files smaller and may be a step towards making our builds more CCACHE_BASEDIR friendly. Try looks happy enough: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1cfbad23c70384324ced0beb812ebd7289c6a18 There may be other places I'm unaware of that nowadays require absolute paths though.
Reporter | ||
Comment 1•7 years ago
|
||
The build system may well have changed sufficiently over the years that this is not the only change that would be required.
Attachment #8924370 -
Flags: review?(core-build-config-reviews)
Comment 2•7 years ago
|
||
Comment on attachment 8924370 [details] [diff] [review] patch We should probably just remove _VPATH_SRCS at this point and replace with $< where it's used, as it no longer seems to have any use. Note that the non-unified files still have full paths (eg: jsarray.cpp), so you may still have the same caching issues with those if that's your end goal.
Attachment #8924370 -
Flags: review?(core-build-config-reviews) → review+
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/80798ac3e0de Have the build system use relative paths to specify the source files that should be built. r=mshal
Comment 4•7 years ago
|
||
Backed out for static build bustage on Linux at chromium/sandbox/linux/bpf_dsl/bpf_dsl.cc:104: bad implicit conversion constructor for 'ConstBoolExprImpl': https://hg.mozilla.org/integration/mozilla-inbound/rev/aed9ec52c5b85db8422757eb6774fe2b8e5c45dd Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=b8d6110960ac12692c5dddf46063425459790e8c&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=retry Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=143013633&repo=mozilla-inbound /builds/worker/workspace/build/src/security/sandbox/linux/../chromium/sandbox/linux/bpf_dsl/bpf_dsl.cc:104:3: error: bad implicit conversion constructor for 'ConstBoolExprImpl'
Flags: needinfo?(jwatt)
Reporter | ||
Comment 5•7 years ago
|
||
I don't see why this change would cause the compilation of security/sandbox/chromium/sandbox/linux/bpf_dsl/bpf_dsl.cc to change at all. The command from the log file - broken across multiple lines to make it easier to read - shows that no relative paths were used: /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -std=gnu++11 -o bpf_dsl.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DNS_NO_XPCOM -I/builds/worker/workspace/build/src/security/sandbox/linux -I/builds/worker/workspace/build/src/obj-firefox/security/sandbox/linux -I/builds/worker/workspace/build/src/security/sandbox/linux -I/builds/worker/workspace/build/src/security/sandbox/chromium-shim -I/builds/worker/workspace/build/src/security/sandbox/chromium -I/builds/worker/workspace/build/src/nsprpub -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++11-compat-pedantic -Wc++14-compat -Wc++14-compat-pedantic -Wc++1z-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wno-gnu-zero-variadic-macro-arguments -Wformat-security -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -D_GLIBCXX_USE_CXX11_ABI=0 -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -Os -fno-omit-frame-pointer -Werror -Wno-shadow -MD -MP -MF .deps/bpf_dsl.o.pp /builds/worker/workspace/build/src/security/sandbox/linux/../chromium/sandbox/linux/bpf_dsl/bpf_dsl.cc
Flags: needinfo?(jwatt)
Updated•6 years ago
|
Product: Core → Firefox Build System
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•