Closed Bug 1413758 Opened 7 years ago Closed 7 years ago

Update "Make a donation" link in About Firefox menu

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 58
Tracking Flags:
Tracking Status
firefox57 --- wontfix
firefox58 --- verified

People

(Reporter: cade, Assigned: cade)

Details

Attachments

(1 file, 1 obsolete file)

Bug 1413758 - Update the 'Make a donation' href attribute on the About Firefox menu,
59 bytes, text/x-review-board-request
Gijs
: review+
Details 
The "About Firefox" popup menu contains a link to "sendto.mozilla.org" a domain that The Mozilla Foundation hasn't used for collecting donations in about 2 years. Luckily, it's redirecting to "donate.mozilla.org" but we should update the link to use an up-to-date domain (https://donate.mozilla.org)


For reference, the URL it has is "https://sendto.mozilla.org/page/contribute/Give-Now?source=mozillaorg_default_footer&ref=firefox_about&utm_campaign=firefox_about&tm_source=firefox&tm_medium=referral&utm_content=20140929_FireFoxAbout"
Can you provide the full alternative URL, or perhaps a patch? The link is hardcoded in:

https://dxr.mozilla.org/mozilla-central/rev/cd7217cf05a2332a8fd7b498767a07b2c31ea657/browser/base/content/aboutDialog.xul#133

and duplicated in the l10n file in a localization comment which we should probably also update:

https://dxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/aboutDialog.dtd#44

Also, who would be affected by a change here, do we do any monitoring of how many people use that link etc.? Would it need any other review?
status-firefox57: --- → ?
status-firefox58: --- → affected
Component: Menus → General
Flags: needinfo?(cade)
Oh, and I forgot to ask - is this critical to get into 57? I assume not, also because the window for doing so is pretty much past, but if it *is* then please yelp.
Hi :Gijs,

This is not a priority for FX57, so no rush. I'm working on ensuring that the redirect we have in place on "sendto.mozilla.org" will work for at least another 3 years.


It's been a while since I've contributed code to FX, got a link to some getting started material, so I'll know how to test/generate a patch?

I'll ask our analytics guru if the link should have any GA tags embedded in the link. unless the infrastructure handling the redirect is counting hits, or firefox has instrumented that link somehow, I don't think we have data on how often that link is clicked.
Flags: needinfo?(cade)
(In reply to Chris DeCairos (:cade) from comment #3)
> Hi :Gijs,
> 
> This is not a priority for FX57, so no rush. I'm working on ensuring that
> the redirect we have in place on "sendto.mozilla.org" will work for at least
> another 3 years.

OK, great.
 
> It's been a while since I've contributed code to FX, got a link to some
> getting started material, so I'll know how to test/generate a patch?

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Artifact_builds
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Source_Code/Mercurial
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview-user.html

should all be helpful (for some definition of the word). We're at the stage where the project is 20 years old and we have too much documentation (all outdated in some way, in part because every time someone is annoyed enough to try to fix something, they do it by creating a new page), in part because MDN is horrible at deleting stuff. Please feel free to ping me directly with any questions, in here or on email/IRC/slack. But really, the TL;DR from the commandline should be something like:

<install hg>
hg clone https://hg.mozilla.org/mozilla-central/
cd mozilla-central
./mach bootstrap
(pick artifact desktop build, otherwise follow prompts)
./mach build
<edit the code you want to edit>
./mach build faster
(does a quick rebuild instead of redoing most of the work)
assuming it works, commit:
hg commit -m "Bug 1413758 - some description, r?gijs"
hg push -r . review

> I'll ask our analytics guru if the link should have any GA tags embedded in
> the link. unless the infrastructure handling the redirect is counting hits,
> or firefox has instrumented that link somehow, I don't think we have data on
> how often that link is clicked.

We don't have any instrumentation in the product beyond the link including GA blobs that, AFAICT, the redirect strips (so as you note, it'd need to be server-side hit-counting or something for us to have analytics of that). Of course, perhaps we want to add some while we're updating the link...
status-firefox57: ? → wontfix
Cade -- appropriate GA parameters for the tracking link would be ...
?utm_source=firefox&utm_medium=referral&utm_campaign=firefox_about&utm_content=2017_firefox_about
Will: It's unlikely that this change will even make it to a firefox release until well into next year - so I'm not sure if the string "utm_content=2017_firefox_about" makes sense to include
Cade - ah, ok, I thought you were putting it on the short-term "sendto" redirect.  In that case, you can of course drop the "2017_" part.
:gijs I think I need to get vouched so that I can push to mozreview - Level 1 access I think? mind vouching for me?
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to Chris DeCairos (:cade) from comment #8)
> :gijs I think I need to get vouched so that I can push to mozreview - Level
> 1 access I think? mind vouching for me?

You shouldn't need to - you can push to the https: version of mozreview without any vouches, per http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html . Does that not work? What errors are you getting?

Equally I wouldn't mind vouching to give you L1 access if that is somehow simpler, but I doubt it (you'd need to file a bug, generate ssh keys, and then jump through hoops to get it set up locally...).
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(cade)
I tried following the instructions for https pushing to mozreview. In the one-time step it asks me to do, I get the following error:

> A SSH connection has been established and your account (christopherd@mozillafoundation.org) was found in LDAP.
>
> However, Mercurial access is not currently enabled on your LDAP account.
>
> Please follow the instructions at the following URL to gain Mercurial access:
>
>    https://www.mozilla.org/en-US/about/governance/policies/commit/
Flags: needinfo?(cade)
I just had to set mozilla.ircnick in my .hgrc it seems? Review is up:

https://reviewboard.mozilla.org/r/196398
:gijs I can't actually publish the review - "error publishing review request 196398: Error publishing: Bugzilla error: :Gijs (no reviews; PTO recovery mode) is not currently accepting 'review' requests. (HTTP 500, API Error 225)

Just ping me here to let me know when you're available again for reviews!
(In reply to Chris DeCairos (:cade) from comment #12)
> :gijs I can't actually publish the review - "error publishing review request
> 196398: Error publishing: Bugzilla error: :Gijs (no reviews; PTO recovery
> mode) is not currently accepting 'review' requests. (HTTP 500, API Error 225)
> 
> Just ping me here to let me know when you're available again for reviews!

Fixed, it should work now if you click the 'publish' button on mozreview, sorry about that. I just got back from 3 weeks of PTO yesterday, and am fiiiinally starting to get close to being up-to-date with bugmail... :-)
Assignee: nobody → cade
Status: NEW → ASSIGNED
Comment on attachment 8925148 [details]
Bug 1413758 - Update the 'Make a donation' href attribute on the About Firefox menu,

https://reviewboard.mozilla.org/r/196400/#review201612

r=me

Note that in mozreview, we can't squash things on the web interface, and it seems to me like it'd make sense to combine these two csets when landing, so if you could, please fold the csets and then repush to mozreview (the r+ will carry over).
Attachment #8925148 - Flags: review?(gijskruitbosch+bugs) → review+
Comment on attachment 8925149 [details]
Bug 1413758 - fix utm_content param in donation link,

https://reviewboard.mozilla.org/r/196402/#review201614
Attachment #8925149 - Flags: review?(gijskruitbosch+bugs) → review+
On it - does any of the documentation you linked earlier explain how to fold csets in hg?
(In reply to Chris DeCairos (:cade) from comment #18)
> On it - does any of the documentation you linked earlier explain how to fold
> csets in hg?

Probably not. I think ./mach bootstrap probably enabled the 'histedit' extension, in which case just running:

hg histedit

should give you a git-rebase-interactive style thing that lets you fold one cset into another one. (If it's not enabled, hg will tell you; you can enable it easily by adding it under the [extensions] section in .hgrc .)
Attachment #8925149 - Attachment is obsolete: true
:gijs all set, thanks for the help!
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/92df2c3c1e1a
Update the 'Make a donation' href attribute on the About Firefox menu, r=Gijs
https://hg.mozilla.org/mozilla-central/rev/92df2c3c1e1a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
I have reproduced this bug with Nightly 58.0a1 (2017-11-01) on Windows 8.1 , 64 Bit ! 

This bug's fix is Verified with latest Beta !

Build   ID    20171115114231
User Agent    Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
QA Whiteboard: [testday-20171117]
I also can confirm that 58.0b4 (20171115114231) build is verified fixed on Ubuntu 14.04 x86 and macOS 10.13, too. 
Thank you Sajedul Islam for your testing efforts!
Status: RESOLVED → VERIFIED
status-firefox58: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: