Closed Bug 1413844 Opened 2 years ago Closed 2 years ago

[dt-onboarding] Add UTM parameters to all about:devtools external links

Categories

(DevTools :: General, enhancement, P3)

enhancement

Tracking

(firefox58 fixed)

RESOLVED FIXED
Firefox 58
Tracking Status
firefox58 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Comment on attachment 8926953 [details]
Bug 1413844 - add utm parameters to about:devtools links;

https://reviewboard.mozilla.org/r/198198/#review203790

::: devtools/shim/aboutdevtools/aboutdevtools.js:195
(Diff revision 2)
>    }
>  
> +  // Add Google Analytics parameters to all the external links.
> +  let externalLinks = [...document.querySelectorAll("a.external")];
> +  for (let link of externalLinks) {
> +    let href = link.getAttribute("href") + "?" + GA_PARAMETERS;

Are we certain none of these links already contain request parameters?
Attachment #8926953 - Flags: review?(pbrosset) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d6bb75646859
add utm parameters to about:devtools links;r=pbro
https://hg.mozilla.org/mozilla-central/rev/d6bb75646859
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.