1413858 - Crash in mozilla::ChannelMediaResource::Seek

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Calixte Denizet (:calixte)]

This bug was filed from the Socorro interface and is 
report bp-0d1db772-f6eb-4030-ab8b-bd2e30171102.
=============================================================

There are 8 crashes in nightly 58 with buildid 20171101220120. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1413483.

[1] https://hg.mozilla.org/mozilla-central/rev?node=346ff0f73eaa8a492e2e808a6ee24b1f7017ccb2

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1413858 - Resume() needs to reset mPendingSeekOffset before calling Seek().

Review commit: https://reviewboard.mozilla.org/r/195780/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/195780/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8924515 [details]
Bug 1413858 - Resume() needs to reset mPendingSeekOffset before calling Seek().

https://reviewboard.mozilla.org/r/195780/#review201180

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3aba4a72b8a5
Resume() needs to reset mPendingSeekOffset before calling Seek(). r=gerald

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3aba4a72b8a5