Closed Bug 1413863 Opened 2 years ago Closed 2 years ago

Test for nsBufferedInputStream

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

Attachments

(1 file, 1 obsolete file)

We don't have valid tests. This bug is about implementing it.
Attached patch bufferedTest.patch (obsolete) — Splinter Review
Assignee: nobody → amarchesini
Attachment #8924497 - Flags: review?(bugs)
closure only tests as well
Attachment #8924497 - Attachment is obsolete: true
Attachment #8924497 - Flags: review?(bugs)
Attachment #8924517 - Flags: review?(bugs)
Blocks: 1413920
Comment on attachment 8924517 [details] [diff] [review]
bufferedTest.patch

>+
>+    nsCOMPtr<nsIInputStreamCallback> callback = aCallback;
>+    nsCOMPtr<nsIAsyncInputStream> self = this;
>+
>+    nsCOMPtr<nsIRunnable> r = NS_NewRunnableFunction(
>+      "AsyncWait", [callback, self]() { callback->OnInputStreamReady(self); });

FWIW, using RunnableMethod would make this a tad simpler.


rs+
Attachment #8924517 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/8ea4737e9642
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.