Status

()

enhancement
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

(Blocks 1 bug, {dev-doc-complete, site-compat})

unspecified
mozilla58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
With legacy generators gone we can do this.
Assignee

Comment 1

2 years ago
Posted patch PatchSplinter Review
One wrinkle is that property_iterator_next_impl can currently ThrowStopIteration. We could make it return MagicValue(JS_NO_ITER_VALUE) but returning that doesn't seem very nice.

Because that code is only there to support for-in with CCWs, this patch removes property_iterator_next and handles wrappers explicitly in js::IteratorMore.

Can you think of any problems with this? This should be green on Try.
Attachment #8924556 - Flags: feedback?(evilpies)
Priority: -- → P2
Comment on attachment 8924556 [details] [diff] [review]
Patch

Review of attachment 8924556 [details] [diff] [review]:
-----------------------------------------------------------------

After our discussion yesterday, I am relatively sure that this should be fine https://mozilla.logbot.info/jsapi/20171102#c13799007-c13799234.
Attachment #8924556 - Flags: feedback?(evilpies) → feedback+
Assignee

Comment 3

2 years ago
Comment on attachment 8924556 [details] [diff] [review]
Patch

Changing to r? :)
Attachment #8924556 - Flags: review?(evilpies)
Comment on attachment 8924556 [details] [diff] [review]
Patch

Review of attachment 8924556 [details] [diff] [review]:
-----------------------------------------------------------------

After our discussion yesterday, I am relatively sure that this should be fine https://mozilla.logbot.info/jsapi/20171102#c13799007-c13799234.
Attachment #8924556 - Flags: review?(evilpies) → review+
https://hg.mozilla.org/mozilla-central/rev/73a48b92351a
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Archived the StopIteration page and removed mentions of it in the main docs.
https://developer.mozilla.org/en-US/docs/Archive/Web/StopIteration
You need to log in before you can comment on or make changes to this bug.