Closed
Bug 1413867
Opened 6 years ago
Closed 6 years ago
Remove StopIteration
Categories
(Core :: JavaScript Engine, enhancement, P2)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete, site-compat)
Attachments
(1 file)
|
26.97 KB,
patch
|
evilpie
:
review+
evilpie
:
feedback+
|
Details | Diff | Splinter Review |
With legacy generators gone we can do this.
|
Assignee | |
Comment 1•6 years ago
|
||
One wrinkle is that property_iterator_next_impl can currently ThrowStopIteration. We could make it return MagicValue(JS_NO_ITER_VALUE) but returning that doesn't seem very nice. Because that code is only there to support for-in with CCWs, this patch removes property_iterator_next and handles wrappers explicitly in js::IteratorMore. Can you think of any problems with this? This should be green on Try.
Attachment #8924556 -
Flags: feedback?(evilpies)
|
||
Updated•6 years ago
|
Keywords: dev-doc-needed
|
||
Updated•6 years ago
|
status-firefox58:
--- → affected
Priority: -- → P2
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8924556 [details] [diff] [review] Patch Review of attachment 8924556 [details] [diff] [review]: ----------------------------------------------------------------- After our discussion yesterday, I am relatively sure that this should be fine https://mozilla.logbot.info/jsapi/20171102#c13799007-c13799234.
Attachment #8924556 -
Flags: feedback?(evilpies) → feedback+
|
|
Assignee | |
Comment 3•6 years ago
|
||
Comment on attachment 8924556 [details] [diff] [review] Patch Changing to r? :)
Attachment #8924556 -
Flags: review?(evilpies)
|
|
||
Comment 4•6 years ago
|
||
Comment on attachment 8924556 [details] [diff] [review] Patch Review of attachment 8924556 [details] [diff] [review]: ----------------------------------------------------------------- After our discussion yesterday, I am relatively sure that this should be fine https://mozilla.logbot.info/jsapi/20171102#c13799007-c13799234.
Attachment #8924556 -
Flags: review?(evilpies) → review+
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/73a48b92351a Remove StopIteration object. r=evilpie
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/73a48b92351a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
|
||
Comment 7•6 years ago
|
||
Archived the StopIteration page and removed mentions of it in the main docs. https://developer.mozilla.org/en-US/docs/Archive/Web/StopIteration
Keywords: dev-doc-needed → dev-doc-complete
|
||
Comment 8•6 years ago
|
||
Posted the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2017/legacy-generator-support-has-been-removed/
Keywords: site-compat
You need to log in
before you can comment on or make changes to this bug.
Description
•