Remove unused JS capability macros

RESOLVED FIXED in Firefox 58

Status

()

Core
JavaScript Engine
RESOLVED FIXED
18 days ago
18 days ago

People

(Reporter: evilpie, Assigned: evilpie)

Tracking

unspecified
mozilla58
Points:
---

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

18 days ago
Created attachment 8924527 [details] [diff] [review]
Remove unused JS capability macros

I don't see any value in keeping those around.
Attachment #8924527 - Flags: review?(arai.unmht)
Comment on attachment 8924527 [details] [diff] [review]
Remove unused JS capability macros

Review of attachment 8924527 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with one fix.

::: js/src/jsversion.h
@@ -20,4 @@
>  #define JS_HAS_FOR_EACH_IN      1       /* has for each (lhs in iterable) */
> -#define JS_HAS_GENERATORS       1       /* (no longer used) */
> -#define JS_HAS_BLOCK_SCOPE      1       /* (no longer used) */
> -#define JS_HAS_DESTRUCTURING    2       /* (no longer used) */

JS_HAS_DESTRUCTURING is used just below.
please remove JS_HAS_DESTRUCTURING_SHORTHAND as well.

@@ -25,4 @@
>  #define JS_HAS_EXPR_CLOSURES    1       /* has function (formals) listexpr */
>  
>  /* (no longer used) */
>  #define JS_HAS_NEW_GLOBAL_OBJECT        1

this also can be removed.
Attachment #8924527 - Flags: review?(arai.unmht) → review+

Comment 2

18 days ago
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1576d8e9cb7
Remove unused JS capability macros. r=arai
https://hg.mozilla.org/mozilla-central/rev/c1576d8e9cb7
Status: NEW → RESOLVED
Last Resolved: 18 days ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.