Closed
Bug 1413901
Opened 7 years ago
Closed 7 years ago
MozURL uses private necko header
Categories
(Core :: Networking, defect, P3)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: bkelly, Assigned: baku)
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
|
3.72 KB,
patch
|
valentin
:
review+
|
Details | Diff | Splinter Review |
I'm trying to use MozURL in some code and running into a compile failure: 0:39.30 /srv/mozilla-central/obj-x86_64-pc-linux-gnu-optdebug/dist/include/mozilla/net/MozURL.h:8:10: fatal error: 'rust-url-capi/src/rust-url-capi.h' file not found 0:39.30 #include "rust-url-capi/src/rust-url-capi.h" It appears if I add netwerk/base to my include path this will work, but it would be nice if the header was publicly exported or hidden from the public MozURL.h.
|
||
Comment 1•7 years ago
|
||
Valentin, can you take a look?
Flags: needinfo?(valentin.gosu)
Priority: -- → P3
Whiteboard: [necko-triaged]
|
Assignee | |
Comment 2•7 years ago
|
||
Working on something else, I wrote this to fix this issue.
Assignee: nobody → amarchesini
Flags: needinfo?(valentin.gosu)
Attachment #8924579 -
Flags: review?(valentin.gosu)
|
||
Updated•7 years ago
|
Attachment #8924579 -
Flags: review?(valentin.gosu) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ecf551e606dd Move rust-url-capi.h include in the MozURL.cpp, r=valentin
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ecf551e606dd
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•