Closed Bug 1413901 Opened 2 years ago Closed 2 years ago

MozURL uses private necko header

Categories

(Core :: Networking, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: bkelly, Assigned: baku)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

I'm trying to use MozURL in some code and running into a compile failure:

 0:39.30 /srv/mozilla-central/obj-x86_64-pc-linux-gnu-optdebug/dist/include/mozilla/net/MozURL.h:8:10: fatal error: 'rust-url-capi/src/rust-url-capi.h' file not found
 0:39.30 #include "rust-url-capi/src/rust-url-capi.h"

It appears if I add netwerk/base to my include path this will work, but it would be nice if the header was publicly exported or hidden from the public MozURL.h.
Valentin, can you take a look?
Flags: needinfo?(valentin.gosu)
Priority: -- → P3
Whiteboard: [necko-triaged]
Attached patch mozurl.patchSplinter Review
Working on something else, I wrote this to fix this issue.
Assignee: nobody → amarchesini
Flags: needinfo?(valentin.gosu)
Attachment #8924579 - Flags: review?(valentin.gosu)
Attachment #8924579 - Flags: review?(valentin.gosu) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ecf551e606dd
Move rust-url-capi.h include in the MozURL.cpp, r=valentin
https://hg.mozilla.org/mozilla-central/rev/ecf551e606dd
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.