Closed
Bug 1413938
Opened 7 years ago
Closed 7 years ago
remove setScalingStyles and set css variables in component
Categories
(DevTools :: Netmonitor, enhancement, P3)
DevTools
Netmonitor
Tracking
(firefox58 fixed)
RESOLVED
FIXED
Firefox 58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: gasolin, Assigned: gasolin)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
== clone from bug 1308695 comment 14 == After upgrade to react 15.6.x we can set css variables in component, so `setScalingStyles` is not needed now http://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/components/RequestListContent.js#120 DAMP test looks good for netmonitor Simple.netmonitor.open 535.19 > 512.56 -4.23% (med) https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=mozilla-central&newProject=try&newRevision=655f1538d45fbe8821315ce69f44d0b257955ae0&originalSignature=edaec66500db21d37602c99daa61ac983f21a6ac&newSignature=edaec66500db21d37602c99daa61ac983f21a6ac&filter=netmonitor&framework=1&selectedTimeRange=172800
Updated•7 years ago
|
Blocks: devtools-performance
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
clean PR with the latest DAMP result https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=mozilla-central&newProject=try&newRevision=0a39263e166731833398c87604d04e83e051ea57&originalSignature=edaec66500db21d37602c99daa61ac983f21a6ac&newSignature=edaec66500db21d37602c99daa61ac983f21a6ac&filter=netmonitor&framework=1&selectedTimeRange=172800 shows no promising perf gain/drop, but with cleaner code
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•7 years ago
|
||
Here's the reference of React 15.16.0 changelog https://github.com/facebook/react/blob/master/CHANGELOG.md#react-dom-3 * Add support for CSS variables in style attribute. (@aweary in #9302)
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8924582 [details] Bug 1413938 - remove setScalingStyles and set css variables in component; https://reviewboard.mozilla.org/r/195812/#review201354 Looks reasonable, thanks Fred! Honza
Attachment #8924582 -
Flags: review?(odvarko) → review+
Comment 6•7 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 4db85ff6eff1 -d 3b5994fa88ee: rebasing 432085:4db85ff6eff1 "Bug 1413938 - remove setScalingStyles and set css variables in component;r=Honza" (tip) merging devtools/client/netmonitor/src/components/RequestListContent.js warning: conflicts while merging devtools/client/netmonitor/src/components/RequestListContent.js! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request) |
Comment 8•7 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 7b2bad7b7383 -d 92df2c3c1e1a: rebasing 432092:7b2bad7b7383 "Bug 1413938 - remove setScalingStyles and set css variables in component;r=Honza" (tip) merging devtools/client/netmonitor/src/components/RequestListContent.js warning: conflicts while merging devtools/client/netmonitor/src/components/RequestListContent.js! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request) |
Comment 10•7 years ago
|
||
Pushed by flin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f21886b3741e remove setScalingStyles and set css variables in component;r=Honza
Comment 11•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f21886b3741e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•