Closed Bug 1413938 Opened 2 years ago Closed 2 years ago

remove setScalingStyles and set css variables in component

Categories

(DevTools :: Netmonitor, enhancement, P3)

enhancement

Tracking

(firefox58 fixed)

RESOLVED FIXED
Firefox 58
Tracking Status
firefox58 --- fixed

People

(Reporter: gasolin, Assigned: gasolin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Here's the reference of React 15.16.0 changelog https://github.com/facebook/react/blob/master/CHANGELOG.md#react-dom-3
* Add support for CSS variables in style attribute. (@aweary in #9302)
Comment on attachment 8924582 [details]
Bug 1413938 - remove setScalingStyles and set css variables in component;

https://reviewboard.mozilla.org/r/195812/#review201354

Looks reasonable, thanks Fred!

Honza
Attachment #8924582 - Flags: review?(odvarko) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 4db85ff6eff1 -d 3b5994fa88ee: rebasing 432085:4db85ff6eff1 "Bug 1413938 - remove setScalingStyles and set css variables in component;r=Honza" (tip)
merging devtools/client/netmonitor/src/components/RequestListContent.js
warning: conflicts while merging devtools/client/netmonitor/src/components/RequestListContent.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 7b2bad7b7383 -d 92df2c3c1e1a: rebasing 432092:7b2bad7b7383 "Bug 1413938 - remove setScalingStyles and set css variables in component;r=Honza" (tip)
merging devtools/client/netmonitor/src/components/RequestListContent.js
warning: conflicts while merging devtools/client/netmonitor/src/components/RequestListContent.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by flin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f21886b3741e
remove setScalingStyles and set css variables in component;r=Honza
https://hg.mozilla.org/mozilla-central/rev/f21886b3741e
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.