Closed Bug 1413976 Opened 6 years ago Closed 5 years ago

Build docker images and toolchains (or optimize them) rather than trying to use indexes.

Categories

(Thunderbird :: Build Config, enhancement)

Product:
Thunderbird
Component:
Build Config
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 59.0

People

(Reporter: tomprince, Assigned: tomprince)

References

Details

Attachments

(1 file, 2 obsolete files)

Bug 1413976: Support defining toolchain and docker-image tasks by reference to mozilla-centrals definitions;
59 bytes, text/x-review-board-request
dustin
: review+
Details 
Rather having to add support for looking for toolchain dependencies by index and dealing with things like Bug 1408574, have thunderbirds taskgraph include building images and toolchains (which should be optimized away most of the time anyway).

My one concern is that we currently use the same namespace as thunderbird. However, since we aren't defining any of these tasks, and just referencing the upstream ones, we should never actually build these, and even if we did, the job definition will be identical to the one firefox would define anyway.
Comment on attachment 8924614 [details]
Bug 1413976: Support defining toolchain and docker-image tasks by reference to mozilla-centrals definitions;

https://reviewboard.mozilla.org/r/195842/#review201442

::: commit-message-f76b3:1
(Diff revision 1)
> +Bug 1413976: Support defining toolchains tasks by reference to mozilla-centrals definitions; r?dustin

This is pretty clever! :)

::: build/virtualenv_packages.txt:1
(Diff revision 1)
> +comm.pth:comm/taskcluster

included by mistake?

::: taskcluster/comm_taskgraph/__init__.py:15
(Diff revision 1)
> +
> +    if kind == 'toolchain':
> +        if job['run'].get('toolchain-alias'):
> +            aliases.add(job['run'].get('toolchain-alias'))
> +
> +    return aliases

This is a little icky, with toolchain-specific stuff in a general loader.  But makes sense for now.
Attachment #8924614 - Flags: review?(dustin) → review+
Comment on attachment 8924613 [details]
Bug 1413976: Build docker images, rather than using indexed images;

https://reviewboard.mozilla.org/r/195840/#review201444

Why not do image tasks by reference, too?
Attachment #8924613 - Flags: review?(dustin) → review+
Comment on attachment 8924614 [details]
Bug 1413976: Support defining toolchain and docker-image tasks by reference to mozilla-centrals definitions;

https://reviewboard.mozilla.org/r/195842/#review201442

> included by mistake?

Nope. This is how the loader gets onto the path.
Comment on attachment 8924613 [details]
Bug 1413976: Build docker images, rather than using indexed images;

https://reviewboard.mozilla.org/r/195840/#review201444

Mostly because this was written before I wrote the reference code, but also partly because the kind definition was so easy. But it probably does make sense to change this too.
Depends on: 1415619
Attachment #8924613 - Attachment is obsolete: true
Attachment #8929658 - Attachment is obsolete: true
As discussed on IRC, I'll land this when bug 1415619 merges.
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/502d6658a41d
Support defining toolchain and docker-image tasks by reference to mozilla-centrals definitions; r=dustin
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 59.0
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/comm-central/rev/b1e4499b6989
Update sync exceptions for having our own virtualenv packages; r=me
You need to log in before you can comment on or make changes to this bug.