Closed Bug 1413979 Opened 2 years ago Closed 2 years ago

Remove bogus styles from tree.css on Linux

Categories

(Toolkit :: Themes, enhancement, P1)

All
Linux
enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

There's a bunch of borders that aren't used because of -moz-appearance, and treecols have extra padding that shouldn't be there because -moz-appearance takes care of that. For treecol[dragging="true"] we set color: ThreeDHighlight on the assumption that background-color is ThreeDShadow, but that background-color isn't used either because of -moz-appearance.
Priority: -- → P1
Comment on attachment 8924616 [details]
Bug 1413979 - Remove bogus styles from tree.css on Linux.

https://reviewboard.mozilla.org/r/195848/#review201408

This seems fine from a relatively shallow inspection, there's just one thing I noticed. It would be good to clarify that.

::: toolkit/themes/linux/global/tree.css
(Diff revision 1)
> -  -moz-border-bottom-colors: ThreeDShadow transparent;
> -  -moz-border-left-colors: ThreeDShadow -moz-Dialog;
> -  padding-top: 0px;
> -  padding-bottom: 0px;
> -  padding-inline-start: 3px;
> -  padding-inline-end: 1px;

Before this change, the treecol had a clear active state (it got additional padding so that it looked "pressed"), but that seems gone now. Are you sure that's intended?
Attachment #8924616 - Flags: review?(jhofmann) → review+
(In reply to Johann Hofmann [:johannh] from comment #2)
> ::: toolkit/themes/linux/global/tree.css
> (Diff revision 1)
> > -  -moz-border-bottom-colors: ThreeDShadow transparent;
> > -  -moz-border-left-colors: ThreeDShadow -moz-Dialog;
> > -  padding-top: 0px;
> > -  padding-bottom: 0px;
> > -  padding-inline-start: 3px;
> > -  padding-inline-end: 1px;
> 
> Before this change, the treecol had a clear active state (it got additional
> padding so that it looked "pressed"), but that seems gone now. Are you sure
> that's intended?

Yep, this doesn't seem Gtk-native behavior. I checked in Nautilus.
(In reply to Dão Gottwald [::dao] from comment #3)
> (In reply to Johann Hofmann [:johannh] from comment #2)
> > ::: toolkit/themes/linux/global/tree.css
> > (Diff revision 1)
> > > -  -moz-border-bottom-colors: ThreeDShadow transparent;
> > > -  -moz-border-left-colors: ThreeDShadow -moz-Dialog;
> > > -  padding-top: 0px;
> > > -  padding-bottom: 0px;
> > > -  padding-inline-start: 3px;
> > > -  padding-inline-end: 1px;
> > 
> > Before this change, the treecol had a clear active state (it got additional
> > padding so that it looked "pressed"), but that seems gone now. Are you sure
> > that's intended?
> 
> Yep, this doesn't seem Gtk-native behavior. I checked in Nautilus.

Ah, ok, thanks for clarifying!
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/db5158176404
Remove bogus styles from tree.css on Linux. r=johannh
https://hg.mozilla.org/mozilla-central/rev/db5158176404
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Blocks: 1327899
You need to log in before you can comment on or make changes to this bug.