1413979 - Remove bogus styles from tree.css on Linux

Status: RESOLVED FIXED

(Toolkit :: Themes, enhancement, P1)

Description

[Dão Gottwald [:dao]]

There's a bunch of borders that aren't used because of -moz-appearance, and treecols have extra padding that shouldn't be there because -moz-appearance takes care of that. For treecol[dragging="true"] we set color: ThreeDHighlight on the assumption that background-color is ThreeDShadow, but that background-color isn't used either because of -moz-appearance.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1413979 - Remove bogus styles from tree.css on Linux.

There's a bunch of borders that aren't used because of -moz-appearance, and treecols have extra padding that shouldn't be there because -moz-appearance takes care of that. For treecol[dragging="true"] we set color: ThreeDHighlight on the assumption that background-color is ThreeDShadow, but that background-color isn't used either because of -moz-appearance.

Review commit: https://reviewboard.mozilla.org/r/195848/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/195848/

Comment 2

[Johann Hofmann [:johannh]]

Comment on attachment 8924616 [details]
Bug 1413979 - Remove bogus styles from tree.css on Linux.

https://reviewboard.mozilla.org/r/195848/#review201408

This seems fine from a relatively shallow inspection, there's just one thing I noticed. It would be good to clarify that.

::: toolkit/themes/linux/global/tree.css
(Diff revision 1)
> -  -moz-border-bottom-colors: ThreeDShadow transparent;
> -  -moz-border-left-colors: ThreeDShadow -moz-Dialog;
> -  padding-top: 0px;
> -  padding-bottom: 0px;
> -  padding-inline-start: 3px;
> -  padding-inline-end: 1px;

Before this change, the treecol had a clear active state (it got additional padding so that it looked "pressed"), but that seems gone now. Are you sure that's intended?

Comment 3

[Dão Gottwald [:dao]]

(In reply to Johann Hofmann [:johannh] from comment #2)
> ::: toolkit/themes/linux/global/tree.css
> (Diff revision 1)
> > -  -moz-border-bottom-colors: ThreeDShadow transparent;
> > -  -moz-border-left-colors: ThreeDShadow -moz-Dialog;
> > -  padding-top: 0px;
> > -  padding-bottom: 0px;
> > -  padding-inline-start: 3px;
> > -  padding-inline-end: 1px;
> 
> Before this change, the treecol had a clear active state (it got additional
> padding so that it looked "pressed"), but that seems gone now. Are you sure
> that's intended?

Yep, this doesn't seem Gtk-native behavior. I checked in Nautilus.

Comment 4

[Johann Hofmann [:johannh]]

(In reply to Dão Gottwald [::dao] from comment #3)
> (In reply to Johann Hofmann [:johannh] from comment #2)
> > ::: toolkit/themes/linux/global/tree.css
> > (Diff revision 1)
> > > -  -moz-border-bottom-colors: ThreeDShadow transparent;
> > > -  -moz-border-left-colors: ThreeDShadow -moz-Dialog;
> > > -  padding-top: 0px;
> > > -  padding-bottom: 0px;
> > > -  padding-inline-start: 3px;
> > > -  padding-inline-end: 1px;
> > 
> > Before this change, the treecol had a clear active state (it got additional
> > padding so that it looked "pressed"), but that seems gone now. Are you sure
> > that's intended?
> 
> Yep, this doesn't seem Gtk-native behavior. I checked in Nautilus.

Ah, ok, thanks for clarifying!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db5158176404
Remove bogus styles from tree.css on Linux. r=johannh

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/db5158176404